fix(federation): leave a room is not propagating (#37206)

Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>

Author: rodrigok

apps/meteor/app/lib/server/functions/removeUserFromRoom.ts

@@ -73,7 +73,7 @@ export const removeUserFromRoom = async function (rid: string, user: IUser, opti
 	}
 
 	// TODO: CACHE: maybe a queue?
-	await afterLeaveRoomCallback.run(user, room);
+	await afterLeaveRoomCallback.run({ user, kicker: options?.byUser }, room);
 
 	void notifyOnRoomChangedById(rid);
 

apps/meteor/ee/server/hooks/federation/index.ts

@@ -121,9 +121,9 @@ callbacks.add(
 );
 
 afterLeaveRoomCallback.add(
-	async (user: IUser, room: IRoom): Promise<void> => {
+	async ({ user, kicker }, room: IRoom): Promise<void> => {
 		if (FederationActions.shouldPerformFederationAction(room)) {
-			await FederationMatrix.leaveRoom(room._id, user);
+			await FederationMatrix.leaveRoom(room._id, user, kicker);
 		}
 	},
 	callbacks.priority.HIGH,

apps/meteor/lib/callbacks/afterLeaveRoomCallback.ts

@@ -2,4 +2,4 @@ import type { IUser, IRoom } from '@rocket.chat/core-typings';
 
 import { Callbacks } from './callbacksBase';
 
-export const afterLeaveRoomCallback = Callbacks.create<(user: IUser, room: IRoom) => void>('afterLeaveRoom');
+export const afterLeaveRoomCallback = Callbacks.create<(data: { user: IUser; kicker?: IUser }, room: IRoom) => void>('afterLeaveRoom');

ee/packages/federation-matrix/src/FederationMatrix.ts

@@ -732,7 +732,12 @@ export class FederationMatrix extends ServiceClass implements IFederationMatrixS
 		return this.homeserverServices.event.getEventById(eventId);
 	}
 
-	async leaveRoom(roomId: string, user: IUser): Promise<void> {
+	async leaveRoom(roomId: string, user: IUser, kicker?: IUser): Promise<void> {
+		if (kicker && isUserNativeFederated(kicker)) {
+			this.logger.debug('Only local users can remove others, ignoring action');
+			return;
+		}
+
 		try {
 			const room = await Rooms.findOneById(roomId);
 			if (!room || !isRoomNativeFederated(room)) {
@@ -745,12 +750,6 @@ export class FederationMatrix extends ServiceClass implements IFederationMatrixS
 				return;
 			}
 
-			const subscription = await Subscriptions.findOne({ 'rid': room._id, 'u._id': user._id });
-			if (!subscription) {
-				this.logger.debug(`User ${user.username} is not subscribed to room ${room._id}, skipping leave operation`);
-				return;
-			}
-
 			const actualMatrixUserId = isUserNativeFederated(user) ? user.federation.mui : `@${user.username}:${this.serverName}`;
 
 			await this.homeserverServices.room.leaveRoom(roomIdSchema.parse(room.federation.mrid), userIdSchema.parse(actualMatrixUserId));

packages/core-services/src/types/IFederationMatrixService.ts

@@ -10,7 +10,7 @@ export interface IFederationMatrixService {
 	sendReaction(messageId: string, reaction: string, user: IUser): Promise<void>;
 	removeReaction(messageId: string, reaction: string, user: IUser, oldMessage: IMessage): Promise<void>;
 	getEventById(eventId: string): Promise<EventStore | null>;
-	leaveRoom(rid: IRoomFederated['_id'], user: IUser): Promise<void>;
+	leaveRoom(rid: IRoomFederated['_id'], user: IUser, kicker?: IUser): Promise<void>;
 	kickUser(room: IRoomNativeFederated, removedUser: IUser, userWhoRemoved: IUser): Promise<void>;
 	updateMessage(room: IRoomNativeFederated, message: IMessage): Promise<void>;
 	updateRoomName(rid: string, displayName: string, user: IUser): Promise<void>;