fix: Correct error handling response in API route to return success instead of failure

Author: ggazzo

apps/meteor/app/api/server/v1/misc.ts

@@ -535,7 +535,7 @@ API.v1.addRoute(
 				if (settings.get('Log_Level') === '2') {
 					Meteor._debug(`Exception while invoking method ${method}`, err);
 				}
-				return API.v1.failure(mountResult({ id, error: err }));
+				return API.v1.success(mountResult({ id, error: err }));
 			}
 		},
 	},

apps/meteor/tests/end-to-end/api/methods.ts

@@ -3111,10 +3111,9 @@ describe('Meteor.methods', () => {
 				room = (
 					await createRoom({
 						type: 'd',
-						name: `direct.test.${Date.now()}-${Math.random()}`,
 						username: guestUser.username,
 					})
-				).body.channel;
+				).body.room;
 				createdRooms.push(room);
 			});
 			after(() =>
@@ -3141,9 +3140,8 @@ describe('Meteor.methods', () => {
 					.expect('Content-Type', 'application/json')
 					.expect(200)
 					.expect((res) => {
-						expect(res.body).to.have.property('success', false);
-						expect(res.body).to.have.property('error').that.is.a('string');
-						expect(res.body.error).to.equal('error-cant-invite-for-direct-room');
+						expect(res.body).to.have.property('message').that.is.an('string');
+						expect(res.body.message).to.include('error-cant-invite-for-direct-room');
 					})
 					.end(done);
 			});