chore(desktop): Remove non-functional "none" option from notification sound dropdown

[Ansh-dS]

Description

The "Default" and "None" options in the notification sound dropdown were not producing any sound, leading to inconsistency.

Steps to Reproduce

1. Choose any channel.
2. Click on the three dots (channel).
3. Navigate to "Notification Preference."
4. Click on "Desktop" and then "Sound."

Expected Behavior

• The dropdown menu should either have a "None" option that correctly disables sound or should not include it to prevent confusion.

Actual Behavior

• The "None" option was present but did not produce any sound, leading to inconsistency and confusion for users.

[Ansh-dS]

#35155

[reetp]

Why do you want to remove the silent/no notification option?

As in

Notifications: None

Maybe users want it?

"None" means "no sound notification".

I would expect no sound.

Please explain further.

[Ansh-dS]

I propose removing the "none" option because "default" currently serves the same function (producing no sound). Having two options for no sound creates redundancy.

To resolve this, we have two potential solutions:
1.Provide a Sound for "Default":
For this, I need additional information as I've already reviewed the code.
2.Remove Either "None" or "Default":
Removing "default" seems more consistent, as other options like mobile and alerts
use "default".

but your point is also correct (to remove "default" instead of "none") since you are only considering sound dropdown, but I have seen other dropdowns too( so I thought to remove 'None')

[reetp]

Thanks for the contribution.

I will ask for review.

You need to be very patient as the team are very busy.

It can take months for code to be merged.

[gabriellsh]

I think the're might be a misconception here. In order to make the correct decision, we must first understand how it's supposed to work, instead of basing the decision on how it's currently working.

"Default" notification sound means that the sound that will be played is the same as configured globally (user preferences). "None" means that no sound should be played.

Now that we understand how it's supposed to work, we can be more assertive. So, if "Default" is playing no sound, 2 things can be happening.

1. The user preference notification sound is set to none. If that's the case, default will play no sound, so that's expected.
2. The "Default" option is broken, not respecting the user preference. This would be considered a bug, and the fix would be to restore the desired behaviour.

Given this information, I did some testing, and everything seems to be working fine. When I set it to default, it plays the sound that I set in the user preferences. When I set none, it doesn't play a sound. I also checked the code for it, and I don't see any possible issues there, or special cases that could be broken.

For now I'll be closing this issue. Please check again and make sure you have a notification sound configured for your user. If that's the case, and the issue still happens, please open a new one and provide a step by step on how to reproduce, every info is needed (user preferences, sound volume, room type (channel, private, team, etc), room settings, server version, browser & browser version (or desktop app and version), etc). Rocket.Chat is a very complex platform and there are many variables that can impact the behaviour.

P.S: You tagged this issue as chore(desktop), and that makes it seem like the issue is on the standalone desktop app. If that's the case, there's an exclusive repository for it.
P.S/2: This is a bug report, but you framed it as a feature request. When reporting issues, make sure to describe exactly what is not working, instead of describing how it could be fixed. Example title: "Default" sound notification option in room notification preferences not working
P.S/3: When you open an issue, there's a template. Make sure to read it (and attached links) and provide all the information it is requesting.

Thank you for taking time to help us improve. I'll be waiting on your response after you test again with the given context.