-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Open
Labels
type: featurePull requests that introduces new featurePull requests that introduces new feature
Description
Description:
Menu in livechat currently declares ref?: any and PopoverMenuWrapper relies on a legacy component-instance shape (Component & { base: Element }). This bypasses strict typing and can hide ref mismatches between Menu and its consumers.
Expected behavior:
Menushould typereffrom the actual rendered element contract (HTMLDivElement) instead ofany.PopoverMenuWrappershould store/use a DOM ref (HTMLDivElement | null) and callgetBoundingClientRect()directly without .base.
Actual behavior:
MenuPropsusesref?: any.PopoverMenuWrapperusesmenuRef?.base?.getBoundingClientRect(), coupling to a legacy component ref shape and weakening type safety.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type: featurePull requests that introduces new featurePull requests that introduces new feature