-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Closed
Labels
invalidA contribution that doesn't fit our standards, looks like spam or is duplicatedA contribution that doesn't fit our standards, looks like spam or is duplicatedtype: bug
Description
Description:
rocketChatUpdated is defined as a deprecated link constant in two places, but it points to a dead URL:
| rocketChatUpdated: 'https://rocket.chat/updated', |
| rocketChatUpdated: 'https://rocket.chat/updated', |
This URL redirects to https://www.rocket.chat/updated, which returns 404.
Even though this key is deprecated, it is still exported and can be used by consumers, so it should not resolve to a dead page.
Steps to reproduce:
- Open
apps/meteor/client/lib/links.tsandpackages/ui-client/src/lib/links.ts. - Locate
rocketChatUpdated. - Open
https://rocket.chat/updatedin a browser (or runcurl -I https://rocket.chat/updated). - Follow redirect to
https://www.rocket.chat/updated.
Expected behavior:
rocketChatUpdated should resolve to a valid update-related URL (HTTP 200), while preserving backward compatibility for consumers using this deprecated key.
Actual behavior:
https://rocket.chat/updated redirects to https://www.rocket.chat/updated, which returns 404 Not Found.
Server Setup Information:
- Version of Rocket.Chat Server: N/A (source-level links constant issue)
- License Type: N/A
- Number of Users: N/A
- Operating System: N/A
- Deployment Method: N/A
- Number of Running Instances: N/A
- DB Replicaset Oplog: N/A
- NodeJS Version: N/A
- MongoDB Version: N/A
Client Setup Information
- Desktop App or Browser Version: Any
- Operating System: Any
Additional context
Suggested fix direction:
- Keep the
rocketChatUpdatedkey (backward compatibility). - Repoint it to a valid maintained update URL (for example
links.go.updateProduct/https://go.rocket.chat/i/update-product) in both files.
Relevant logs:
HTTP response chain:
https://rocket.chat/updated->301redirecthttps://www.rocket.chat/updated->404
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
invalidA contribution that doesn't fit our standards, looks like spam or is duplicatedA contribution that doesn't fit our standards, looks like spam or is duplicatedtype: bug