Backwards incompatible change in version 6.26.0

[steinwelberg]

In version 6.26.0 you have introduced a backwards incompatible change due to the fact that the microservices based deployment has been enabled by default. Furthermore, the release notes are suggesting that the only change is the app version bump, but there are a lot of changes hidden as the real diff is: rocketchat-6.25.2...rocketchat-6.26.0.

[mrakopes]

👍 would be nice to mention those changes in release notes

Isn't it strange to enable microservices by default when its a premium feature only?

Also, the comments in values.yaml are inconsistent now:

# # # # # # # # # # # # # # # # #
#   M I C R O S E R V I C E S   #
#  Only available to E.E users  #
# # # # # # # # # # # # # # # # #

## Deploy as microservices?
# Monolithic architecture, by default
microservices:
  enabled: true

[mrakopes]

there is also inconsistency in external/separate NATS server:

nats:
  # Helm docs: https://helm.sh/docs/topics/charts/#tags-and-condition-resolution
  #
  # IMPORTANT: Do not set nats.enabled here unless you want to override the default behavior.
  # By default, nats.enabled is nil and its deployment is determined by microservices.enabled:
  #   - microservices.enabled: true, nats.enabled: nil        = NATS is enabled and deployed internally, this is the default behavior
  #   - microservices.enabled: true, nats.enabled: false      = NATS is NOT deployed (use external NATS)
  #   - microservices.enabled: false, nats.enabled: true      = Monolith RC with NATS deployed
  #   - microservices.enabled: false, nats.enabled: nil/false = Monolith RC without NATS
  #
  # To deploy NATS, uncomment and set enabled: true below. To use an external NATS, set enabled: false.
  # enabled: true

with microservices.enabled: false, nats.enabled: nil - its creating monolith RC and separate NATS deployment (which is propably never used since its already inside the monolith)

to return to previous default behavior, one must set:

microservices:
  enabled: false
nats:
  enabled: false

[steinwelberg]

there is also inconsistency in external/separate NATS server:

nats:
  # Helm docs: https://helm.sh/docs/topics/charts/#tags-and-condition-resolution
  #
  # IMPORTANT: Do not set nats.enabled here unless you want to override the default behavior.
  # By default, nats.enabled is nil and its deployment is determined by microservices.enabled:
  #   - microservices.enabled: true, nats.enabled: nil        = NATS is enabled and deployed internally, this is the default behavior
  #   - microservices.enabled: true, nats.enabled: false      = NATS is NOT deployed (use external NATS)
  #   - microservices.enabled: false, nats.enabled: true      = Monolith RC with NATS deployed
  #   - microservices.enabled: false, nats.enabled: nil/false = Monolith RC without NATS
  #
  # To deploy NATS, uncomment and set enabled: true below. To use an external NATS, set enabled: false.
  # enabled: true

with microservices.enabled: false, nats.enabled: nil - its creating monolith RC and separate NATS deployment (which is propably never used since its already inside the monolith)

to return to previous default behavior, one must set:

microservices:
enabled: false
nats:
enabled: false

Indeed, that is also what I'm doing