Skip to content

Commit 6be144f

Browse files
committed
chore: remove unneeded try catch block from getServerSetInRoom
1 parent 865e1d1 commit 6be144f

File tree

1 file changed

+18
-27
lines changed

1 file changed

+18
-27
lines changed

packages/federation-sdk/src/services/state.service.ts

Lines changed: 18 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -783,39 +783,30 @@ export class StateService {
783783
// return this.getStateAtStateId(stateId, event.version);
784784
// }
785785
async getServerSetInRoom(roomId: string) {
786-
const servers = new Set<string>();
786+
const state = await this.getLatestRoomState(roomId);
787787

788-
try {
789-
const state = await this.getLatestRoomState(roomId);
788+
const servers = new Set<string>();
790789

791-
for (const event of state.values()) {
792-
if (!event.isMembershipEvent() || event.getMembership() !== 'join') {
793-
continue;
794-
}
790+
for (const event of state.values()) {
791+
if (!event.isMembershipEvent() || event.getMembership() !== 'join') {
792+
continue;
793+
}
795794

796-
try {
797-
const server = extractDomainFromId(event.stateKey as string);
798-
if (server) {
799-
servers.add(server);
800-
}
801-
} catch (error) {
802-
this.logger.error({
803-
err: error,
804-
eventId: event.eventId,
805-
msg: 'error extracting server',
806-
});
795+
try {
796+
const server = extractDomainFromId(event.stateKey as string);
797+
if (server) {
798+
servers.add(server);
807799
}
800+
} catch (error) {
801+
this.logger.error({
802+
err: error,
803+
eventId: event.eventId,
804+
msg: 'error extracting server',
805+
});
808806
}
809-
810-
return servers;
811-
} catch (error) {
812-
this.logger.error({
813-
err: error,
814-
roomId: roomId,
815-
msg: 'error getting server set in room',
816-
});
817-
return servers;
818807
}
808+
809+
return servers;
819810
}
820811

821812
// @deprecated use getServerSetInRoom

0 commit comments

Comments
 (0)