fix: pass correct supported versions list to make_join (#236)

Author: debdutdeb

packages/federation-sdk/src/services/federation-request.service.ts

@@ -121,13 +121,19 @@ export class FederationRequestService {
 		targetServer: string,
 		endpoint: string,
 		body?: Record<string, unknown>,
-		queryParams?: Record<string, string>,
+		queryParams?: Record<string, string | string[]>,
 	) {
 		let queryString = '';
 
 		if (queryParams) {
 			const params = new URLSearchParams();
 			for (const [key, value] of Object.entries(queryParams)) {
+				if (Array.isArray(value)) {
+					for (const v of value) {
+						params.append(key, v);
+					}
+					continue;
+				}
 				params.append(key, value);
 			}
 			queryString = params.toString();
@@ -147,7 +153,7 @@ export class FederationRequestService {
 	async get<T>(
 		targetServer: string,
 		endpoint: string,
-		queryParams?: Record<string, string>,
+		queryParams?: Record<string, string | string[]>,
 	): Promise<T> {
 		return this.request<T>(
 			'GET',

packages/federation-sdk/src/services/federation.service.ts

@@ -6,6 +6,7 @@ import {
 	Pdu,
 	PduForType,
 	PersistentEventBase,
+	PersistentEventFactory,
 } from '@rocket.chat/federation-room';
 import { singleton } from 'tsyringe';
 import {
@@ -43,16 +44,12 @@ export class FederationService {
 	): Promise<MakeJoinResponse> {
 		try {
 			const uri = FederationEndpoints.makeJoin(roomId, userId);
-			const queryParams: Record<string, string> = {};
+			const queryParams: Record<string, string | string[]> = {};
 
 			if (version) {
 				queryParams.ver = version;
 			} else {
-				// 3-11 is what we support now
-				// FIXME: this is wrong, for now just passing 10 to check if supported, we need ver=1&ver=2 and so on.
-				for (let ver = 3; ver <= 11; ver++) {
-					queryParams[`ver${ver === 1 ? '' : ver}`] = ver.toString();
-				}
+				queryParams.ver = PersistentEventFactory.supportedRoomVersions;
 			}
 
 			return await this.requestService.get<MakeJoinResponse>(