removes unnecessary class init state info from controllers

Author: GabrielBarberini

lib/controllers/environment.py

@@ -19,9 +19,6 @@ class EnvController:
     """
     Controller for the Environment model.
 
-    Init Attributes:
-        env: models.Env
-
     Enables:
         - Simulation of a RocketPy Environment from models.Env
         - CRUD operations over models.Env on the database

lib/controllers/flight.py

@@ -25,9 +25,6 @@ class FlightController:
     """
     Controller for the Flight model.
 
-    Init Attributes:
-        flight (models.Flight): Flight model object.
-
     Enables:
         - Create a RocketPyFlight object from a Flight model object.
         - Generate trajectory simulation from a RocketPyFlight object.
@@ -39,34 +36,23 @@ class FlightController:
 
     """
 
-    def __init__(
-        self,
-        flight: Flight,
-    ):
-        self.guard(flight)
-        self._flight = flight
-
-    @property
-    def flight(self) -> Flight:
-        return self._flight
-
-    @flight.setter
-    def flight(self, flight: Flight):
-        self._flight = flight
-
     @staticmethod
     def guard(flight: Flight):
         RocketController.guard(flight.rocket)
 
-    async def create_flight(self) -> Union[FlightCreated, HTTPException]:
+    @classmethod
+    async def create_flight(
+        cls, flight: Flight
+    ) -> Union[FlightCreated, HTTPException]:
         """
         Create a flight in the database.
 
         Returns:
             views.FlightCreated
         """
         try:
-            async with FlightRepository(self.flight) as flight_repo:
+            cls.guard(flight)
+            async with FlightRepository(flight) as flight_repo:
                 await flight_repo.create_flight()
         except PyMongoError as e:
             logger.error(f"controllers.flight.create_flight: PyMongoError {e}")
@@ -189,8 +175,9 @@ async def get_rocketpy_flight_binary(
                 f"Call to controllers.flight.get_rocketpy_flight_binary completed for Flight {flight_id}"
             )
 
+    @classmethod
     async def update_flight_by_id(
-        self, flight_id: str
+        cls, flight: Flight, flight_id: str
     ) -> Union[FlightUpdated, HTTPException]:
         """
         Update a models.Flight in the database.
@@ -205,7 +192,8 @@ async def update_flight_by_id(
             HTTP 404 Not Found: If the flight is not found in the database.
         """
         try:
-            async with FlightRepository(self.flight) as flight_repo:
+            cls.guard(flight)
+            async with FlightRepository(flight) as flight_repo:
                 await flight_repo.update_flight_by_id(flight_id)
         except PyMongoError as e:
             logger.error(f"controllers.flight.update_flight: PyMongoError {e}")

lib/controllers/motor.py

@@ -19,9 +19,6 @@ class MotorController:
     """
     Controller for the motor model.
 
-    Init Attributes:
-        motor (models.Motor): Motor model object.
-
     Enables:
         - Create a rocketpy.Motor object from a Motor model object.
     """

lib/controllers/rocket.py

@@ -22,41 +22,27 @@ class RocketController:
     """
     Controller for the Rocket model.
 
-    Init Attributes:
-        rocket: models.Rocket.
-
     Enables:
        - CRUD operations over models.Rocket on the database.
     """
 
-    def __init__(
-        self,
-        rocket: Rocket,
-    ):
-        self.guard(rocket)
-        self._rocket = rocket
-
-    @property
-    def rocket(self) -> Rocket:
-        return self._rocket
-
-    @rocket.setter
-    def rocket(self, rocket: Rocket):
-        self._rocket = rocket
-
     @staticmethod
     def guard(rocket: Rocket):
         MotorController.guard(rocket.motor)
 
-    async def create_rocket(self) -> Union[RocketCreated, HTTPException]:
+    @classmethod
+    async def create_rocket(
+        cls, rocket: Rocket
+    ) -> Union[RocketCreated, HTTPException]:
         """
         Create a models.Rocket in the database.
 
         Returns:
             views.RocketCreated
         """
         try:
-            async with RocketRepository(self.rocket) as rocket_repo:
+            cls.guard(rocket)
+            async with RocketRepository(rocket) as rocket_repo:
                 await rocket_repo.create_rocket()
         except PyMongoError as e:
             logger.error(f"controllers.rocket.create_rocket: PyMongoError {e}")
@@ -175,8 +161,9 @@ async def get_rocketpy_rocket_binary(
                 f"Call to controllers.rocket.get_rocketpy_rocket_binary completed for Rocket {rocket_id}"
             )
 
+    @classmethod
     async def update_rocket_by_id(
-        self, rocket_id: str
+        cls, rocket: Rocket, rocket_id: str
     ) -> Union[RocketUpdated, HTTPException]:
         """
         Update a models.Rocket in the database.
@@ -191,7 +178,8 @@ async def update_rocket_by_id(
             HTTP 404 Not Found: If the rocket is not found in the database.
         """
         try:
-            async with RocketRepository(self.rocket) as rocket_repo:
+            cls.guard(rocket)
+            async with RocketRepository(rocket) as rocket_repo:
                 await rocket_repo.update_rocket_by_id(rocket_id)
         except PyMongoError as e:
             logger.error(f"controllers.rocket.update_rocket: PyMongoError {e}")

lib/routes/flight.py

@@ -43,7 +43,7 @@ async def create_flight(
     """
     with tracer.start_as_current_span("create_flight"):
         flight.rocket.motor.set_motor_kind(motor_kind)
-        return await FlightController(flight).create_flight()
+        return await FlightController.create_flight(flight)
 
 
 @router.get("/{flight_id}")
@@ -146,7 +146,7 @@ async def update_flight(
     """
     with tracer.start_as_current_span("update_flight"):
         flight.rocket.motor.set_motor_kind(motor_kind)
-        return await FlightController(flight).update_flight_by_id(flight_id)
+        return await FlightController.update_flight_by_id(flight, flight_id)
 
 
 @router.get("/{flight_id}/summary")

lib/routes/rocket.py

@@ -41,7 +41,7 @@ async def create_rocket(
     """
     with tracer.start_as_current_span("create_rocket"):
         rocket.motor.set_motor_kind(motor_kind)
-        return await RocketController(rocket).create_rocket()
+        return await RocketController.create_rocket(rocket)
 
 
 @router.get("/{rocket_id}")
@@ -73,7 +73,7 @@ async def update_rocket(
     """
     with tracer.start_as_current_span("update_rocket"):
         rocket.motor.set_motor_kind(motor_kind)
-        return await RocketController(rocket).update_rocket_by_id(rocket_id)
+        return await RocketController.update_rocket_by_id(rocket, rocket_id)
 
 
 @router.get(