improves HTTP code semantics

Author: GabrielBarberini

src/routes/environment.py

@@ -90,12 +90,12 @@ async def delete_environment(environment_id: str) -> None:
 @router.get(
     "/{environment_id}/rocketpy",
     responses={
-        203: {
+        200: {
             "description": "Binary file download",
             "content": {"application/octet-stream": {}},
         }
     },
-    status_code=203,
+    status_code=200,
     response_class=Response,
 )
 async def get_rocketpy_environment_binary(environment_id: str):
@@ -118,7 +118,7 @@ async def get_rocketpy_environment_binary(environment_id: str):
             content=binary,
             headers=headers,
             media_type="application/octet-stream",
-            status_code=203,
+            status_code=200,
         )
 
 

src/routes/flight.py

@@ -86,12 +86,12 @@ async def delete_flight(flight_id: str) -> None:
 @router.get(
     "/{flight_id}/rocketpy",
     responses={
-        203: {
+        200: {
             "description": "Binary file download",
             "content": {"application/octet-stream": {}},
         }
     },
-    status_code=203,
+    status_code=200,
     response_class=Response,
 )
 async def get_rocketpy_flight_binary(flight_id: str):
@@ -112,7 +112,7 @@ async def get_rocketpy_flight_binary(flight_id: str):
             content=binary,
             headers=headers,
             media_type="application/octet-stream",
-            status_code=203,
+            status_code=200,
         )
 
 

src/routes/motor.py

@@ -84,12 +84,12 @@ async def delete_motor(motor_id: str) -> None:
 @router.get(
     "/{motor_id}/rocketpy",
     responses={
-        203: {
+        200: {
             "description": "Binary file download",
             "content": {"application/octet-stream": {}},
         }
     },
-    status_code=203,
+    status_code=200,
     response_class=Response,
 )
 async def get_rocketpy_motor_binary(motor_id: str):
@@ -110,7 +110,7 @@ async def get_rocketpy_motor_binary(motor_id: str):
             content=binary,
             headers=headers,
             media_type="application/octet-stream",
-            status_code=203,
+            status_code=200,
         )
 
 

src/routes/rocket.py

@@ -84,12 +84,12 @@ async def delete_rocket(rocket_id: str) -> None:
 @router.get(
     "/{rocket_id}/rocketpy",
     responses={
-        203: {
+        200: {
             "description": "Binary file download",
             "content": {"application/octet-stream": {}},
         }
     },
-    status_code=203,
+    status_code=200,
     response_class=Response,
 )
 async def get_rocketpy_rocket_binary(rocket_id: str):
@@ -110,7 +110,7 @@ async def get_rocketpy_rocket_binary(rocket_id: str):
             content=binary,
             headers=headers,
             media_type="application/octet-stream",
-            status_code=203,
+            status_code=200,
         )
 
 

tests/unit/test_routes/test_environments_route.py

@@ -229,7 +229,7 @@ def test_read_rocketpy_environment_binary(mock_controller_instance):
     mock_response = AsyncMock(return_value=b'rocketpy')
     mock_controller_instance.get_rocketpy_environment_binary = mock_response
     response = client.get('/environments/123/rocketpy')
-    assert response.status_code == 203
+    assert response.status_code == 200
     assert response.content == b'rocketpy'
     assert response.headers['content-type'] == 'application/octet-stream'
     mock_controller_instance.get_rocketpy_environment_binary.assert_called_once_with(

tests/unit/test_routes/test_flights_route.py

@@ -339,7 +339,7 @@ def test_read_rocketpy_flight_binary(mock_controller_instance):
         return_value=b'rocketpy'
     )
     response = client.get('/flights/123/rocketpy')
-    assert response.status_code == 203
+    assert response.status_code == 200
     assert response.content == b'rocketpy'
     assert response.headers['content-type'] == 'application/octet-stream'
     mock_controller_instance.get_rocketpy_flight_binary.assert_called_once_with(

tests/unit/test_routes/test_motors_route.py

@@ -385,7 +385,7 @@ def test_read_rocketpy_motor_binary(mock_controller_instance):
     mock_response = AsyncMock(return_value=b'rocketpy')
     mock_controller_instance.get_rocketpy_motor_binary = mock_response
     response = client.get('/motors/123/rocketpy')
-    assert response.status_code == 203
+    assert response.status_code == 200
     assert response.content == b'rocketpy'
     assert response.headers['content-type'] == 'application/octet-stream'
     mock_controller_instance.get_rocketpy_motor_binary.assert_called_once_with(

tests/unit/test_routes/test_rockets_route.py

@@ -446,7 +446,7 @@ def test_read_rocketpy_rocket_binary(mock_controller_instance):
     mock_response = AsyncMock(return_value=b'rocketpy')
     mock_controller_instance.get_rocketpy_rocket_binary = mock_response
     response = client.get('/rockets/123/rocketpy')
-    assert response.status_code == 203
+    assert response.status_code == 200
     assert response.content == b'rocketpy'
     assert response.headers['content-type'] == 'application/octet-stream'
     mock_controller_instance.get_rocketpy_rocket_binary.assert_called_once_with(