refactors API architecture

- wipe business logic from controllers
- turn off entities deletion
- replace hash ids by ObjectIds

disables simulation routes

exposes motor tank property and disable fronzen instances

Author: GabrielBarberini

README.md

@@ -18,7 +18,7 @@ $ touch .env && echo MONGODB_CONNECTION_STRING="$ConnectionString" > .env
 ### Docker
 - run docker compose: `docker-compose up --build -d`
 
-### Standard
+### Standalone 
 - Dev: `python3 -m uvicorn lib:app --reload --port 3000`
 - Prod: `gunicorn -k uvicorn.workers.UvicornWorker lib:app -b 0.0.0.0:3000`
 
@@ -38,6 +38,12 @@ $ touch .env && echo MONGODB_CONNECTION_STRING="$ConnectionString" > .env
 │   │   ├── motor.py
 │   │   └── rocket.py
 │   │   
+│   ├── services 
+│   │   ├── environment.py
+│   │   ├── flight.py
+│   │   ├── motor.py
+│   │   └── rocket.py
+│   │   
 │   ├── routes 
 │   │   ├── environment.py
 │   │   ├── flight.py
@@ -66,43 +72,51 @@ $ touch .env && echo MONGODB_CONNECTION_STRING="$ConnectionString" > .env
 │       └── rocket.py
 │   
 └── tests
-    ├── infinity-api-postman-collection.json
-    │   
     ├── integration 
+    │   ├── test_environment_integration.py
+    │   ├── test_motor_integration.py
+    │   ├── test_rocket_integration.py
+    │   └── test_flight_integration.py
     │   
     └── unit
         ├── test_secrets.py
         ├── test_api.py
         │   
         ├── test_controllers
-        │   ├── test_environment.py
-        │   ├── test_flight.py
-        │   ├── test_motor.py
-        │   └── test_rocket.py
+        │   ├── test_environment_controller.py
+        │   ├── test_flight_controller.py
+        │   ├── test_motor_controller.py
+        │   └── test_rocket_controller.py
+        │   
+        ├── test_services
+        │   ├── test_environment_service.py
+        │   ├── test_flight_service.py
+        │   ├── test_motor_service.py
+        │   └── test_rocket_serice.py
         │
         ├── test_routes
-        │   ├── test_environment.py
-        │   ├── test_flight.py
-        │   ├── test_motor.py
-        │   └── test_rocket.py
+        │   ├── test_environment_route.py
+        │   ├── test_flight_route.py
+        │   ├── test_motor_route.py
+        │   └── test_rocket_route.py
         │
         ├── test_repositories
-        │   ├── test_environment.py
-        │   ├── test_flight.py
-        │   ├── test_motor.py
-        │   └── test_rocket.py
+        │   ├── test_environment_repo.py
+        │   ├── test_flight_repo.py
+        │   ├── test_motor_repo.py
+        │   └── test_rocket_repo.py
         │
         ├── test_models
-        │   ├── test_environment.py
-        │   ├── test_flight.py
-        │   ├── test_motor.py
-        │   └── test_rocket.py
+        │   ├── test_environment_model.py
+        │   ├── test_flight_model.py
+        │   ├── test_motor_model.py
+        │   └── test_rocket_model.py
         │   
         └── test_views
-            ├── test_environment.py
-            ├── test_flight.py
-            ├── test_motor.py
-            └── test_rocket.py
+            ├── test_environment_view.py
+            ├── test_flight_view.py
+            ├── test_motor_view.py
+            └── test_rocket_view.py
 ```
 
 ## DOCS

lib/__init__.py

@@ -22,7 +22,7 @@
 def parse_error(error):
     exc_type = type(error).__name__
     exc_obj = f"{error}".replace("\n", " ").replace("   ", " ")
-    return f"{exc_type} exception: {exc_obj}"
+    return f"{exc_type}: {exc_obj}"
 
 
 from lib.api import app

lib/controllers/environment.py

@@ -48,8 +48,7 @@ async def create_env(self) -> Union[EnvCreated, HTTPException]:
             views.EnvCreated
         """
         try:
-            async with EnvRepository() as env_repo:
-                env_repo.fetch_env(self.env)
+            async with EnvRepository(self.env) as env_repo:
                 await env_repo.create_env()
         except PyMongoError as e:
             logger.error(
@@ -69,10 +68,10 @@ async def create_env(self) -> Union[EnvCreated, HTTPException]:
                 detail=f"Failed to create environment: {exc_str}",
             ) from e
         else:
-            return EnvCreated(env_id=self.env.env_id)
+            return EnvCreated(env_id=env_repo.env_id)
         finally:
             logger.info(
-                f"Call to controllers.environment.create_env completed for Env {hash(self.env)}"
+                f"Call to controllers.environment.create_env completed for Env {env_repo.env_id}"
             )
 
     @staticmethod
@@ -178,10 +177,8 @@ async def update_env_by_id(
             HTTP 404 Not Found: If the env is not found in the database.
         """
         try:
-            async with EnvRepository() as env_repo:
-                env_repo.fetch_env(self.env)
-                await env_repo.create_env()
-                await env_repo.delete_env_by_id(env_id)
+            async with EnvRepository(self.env) as env_repo:
+                await env_repo.update_env_by_id(env_id)
         except PyMongoError as e:
             logger.error(
                 f"controllers.environment.update_env: PyMongoError {e}"
@@ -200,10 +197,10 @@ async def update_env_by_id(
                 detail=f"Failed to update environment: {exc_str}",
             ) from e
         else:
-            return EnvUpdated(new_env_id=self.env.env_id)
+            return EnvUpdated(env_id=env_id)
         finally:
             logger.info(
-                f"Call to controllers.environment.update_env completed for Env {env_id}; Env {hash(self.env)}"
+                f"Call to controllers.environment.update_env completed for Env {env_id}"
             )
 
     @staticmethod
@@ -243,7 +240,7 @@ async def delete_env_by_id(
                 detail=f"Failed to delete environment: {exc_str}",
             ) from e
         else:
-            return EnvDeleted(deleted_env_id=env_id)
+            return EnvDeleted(env_id=env_id)
         finally:
             logger.info(
                 f"Call to controllers.environment.delete_env completed for Env {env_id}"