Skip to content

Commit 7a10e29

Browse files
CopilotaZira371Copilot
authored
TST: Add acceptance tests for 3DOF flight simulation based on Bella Lui rocket (#914)
* TST: Add comprehensive 3DOF acceptance tests Co-authored-by: aZira371 <[email protected]> * Configure 3DOF acceptance tests to skip until feature is available Co-authored-by: aZira371 <[email protected]> * Apply ruff formatting to 3DOF acceptance tests Co-authored-by: aZira371 <[email protected]> * Fix test logic issues based on code review feedback Co-authored-by: aZira371 <[email protected]> * Refactor 3DOF fixtures to flight_fixtures.py and reuse existing environment fixture Co-authored-by: aZira371 <[email protected]> * Remove unnecessary try/except blocks - PointMass classes are available in codebase Co-authored-by: aZira371 <[email protected]> * Refactor acceptance tests with Bella Lui parameters and named constants Co-authored-by: aZira371 <[email protected]> * Use named constants in flight fixtures for consistency Co-authored-by: aZira371 <[email protected]> * Define launch constants at module level to avoid duplication Co-authored-by: aZira371 <[email protected]> * Import launch constants from fixtures to eliminate duplication Co-authored-by: aZira371 <[email protected]> * Fix docstrings to accurately describe fixture relationships Co-authored-by: aZira371 <[email protected]> * Use appropriately named constant for weathercock apogee difference Co-authored-by: aZira371 <[email protected]> * TST: Amend acceptance tests for 3DOF flight simulation based on Bella Lui rocket Co-authored-by: aZira371 <[email protected]> * MNT: Adjust tolerance ranges to match Bella Lui rocket performance Co-authored-by: aZira371 <[email protected]> * Refactor weathercocking tests to verify physics implementation rather than specific tolerances Co-authored-by: aZira371 <[email protected]> * Update tests/acceptance/test_3dof_flight.py Co-authored-by: Copilot <[email protected]> * MNT: removed unused tolerance parameter Co-authored-by: Copilot <[email protected]> * Remove duplicate bella_lui fixtures, keep only acceptance_point_mass fixtures Co-authored-by: aZira371 <[email protected]> * Update tests/acceptance/test_3dof_flight.py Co-authored-by: Copilot <[email protected]> * Fix critical rocket radius and floating-point comparison issues Co-authored-by: aZira371 <[email protected]> * MNT: update changelog.md for PR #914 - MNT: added required line to changelog.md * Improve quaternion test tolerance to account for passive aerodynamic effects Co-authored-by: aZira371 <[email protected]> * MNT: make format check --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: aZira371 <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Ishan <[email protected]>
1 parent ba77fd5 commit 7a10e29

File tree

3 files changed

+628
-0
lines changed

3 files changed

+628
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
3131
Attention: The newest changes should be on top -->
3232

3333
### Added
34+
- TST: Add acceptance tests for 3DOF flight simulation based on Bella Lui rocket [#914] (https://github.com/RocketPy-Team/RocketPy/pull/914_
3435
- ENH: Add background map auto download functionality to Monte Carlo plots [#896](https://github.com/RocketPy-Team/RocketPy/pull/896)
3536
- MNT: net thrust addition to 3 dof in flight class [#907] (https://github.com/RocketPy-Team/RocketPy/pull/907)
3637
- ENH: 3-dof lateral motion improvement [#883](https://github.com/RocketPy-Team/RocketPy/pull/883)

0 commit comments

Comments
 (0)