Skip to content

Commit d4990c2

Browse files
CopilotaZira371
andcommitted
Use named constants in flight fixtures for consistency
Co-authored-by: aZira371 <[email protected]>
1 parent 85a0eff commit d4990c2

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

tests/fixtures/flight/flight_fixtures.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,9 @@ def acceptance_point_mass_rocket(acceptance_point_mass_motor):
475475
def flight_3dof_no_weathercock(example_spaceport_env, acceptance_point_mass_rocket):
476476
"""Create a 3 DOF flight without weathercocking.
477477
478+
Uses standard launch parameters: 85 degrees inclination (5 degrees from vertical)
479+
and 0 degrees heading (north).
480+
478481
Parameters
479482
----------
480483
example_spaceport_env : rocketpy.Environment
@@ -487,12 +490,15 @@ def flight_3dof_no_weathercock(example_spaceport_env, acceptance_point_mass_rock
487490
rocketpy.Flight
488491
A 3 DOF flight simulation with weathercock_coeff=0.0.
489492
"""
493+
LAUNCH_INCLINATION = 85 # degrees from horizontal (5 degrees from vertical)
494+
LAUNCH_HEADING = 0 # degrees (north)
495+
490496
return Flight(
491497
rocket=acceptance_point_mass_rocket,
492498
environment=example_spaceport_env,
493499
rail_length=5.0,
494-
inclination=85, # 85 degrees from horizontal (5 degrees from vertical)
495-
heading=0,
500+
inclination=LAUNCH_INCLINATION,
501+
heading=LAUNCH_HEADING,
496502
simulation_mode="3 DOF",
497503
weathercock_coeff=0.0,
498504
)
@@ -502,6 +508,9 @@ def flight_3dof_no_weathercock(example_spaceport_env, acceptance_point_mass_rock
502508
def flight_3dof_with_weathercock(example_spaceport_env, acceptance_point_mass_rocket):
503509
"""Create a 3 DOF flight with weathercocking enabled.
504510
511+
Uses standard launch parameters: 85 degrees inclination (5 degrees from vertical)
512+
and 0 degrees heading (north).
513+
505514
Parameters
506515
----------
507516
example_spaceport_env : rocketpy.Environment
@@ -514,12 +523,15 @@ def flight_3dof_with_weathercock(example_spaceport_env, acceptance_point_mass_ro
514523
rocketpy.Flight
515524
A 3 DOF flight simulation with weathercock_coeff=1.0.
516525
"""
526+
LAUNCH_INCLINATION = 85 # degrees from horizontal (5 degrees from vertical)
527+
LAUNCH_HEADING = 0 # degrees (north)
528+
517529
return Flight(
518530
rocket=acceptance_point_mass_rocket,
519531
environment=example_spaceport_env,
520532
rail_length=5.0,
521-
inclination=85,
522-
heading=0,
533+
inclination=LAUNCH_INCLINATION,
534+
heading=LAUNCH_HEADING,
523535
simulation_mode="3 DOF",
524536
weathercock_coeff=1.0,
525537
)

0 commit comments

Comments
 (0)