test: fix lint issues

Author: Rogdham

CHANGELOG.md

@@ -14,6 +14,7 @@ adheres to [Semantic Versioning](https://semver.org/).
 - Add tests for CPython 3.10 and PyPy 3.8
 - Use CPython 3.10 for misc. tests
 - Clarify which Python versions are supported in readme
+- Fix some linting issues found by latest versions of mypy/pylint
 
 ## [0.3.0] - 2021-11-07
 

tests/conftest.py

@@ -26,9 +26,10 @@ def pytest_addoption(parser: "Parser") -> None:
 def pytest_collection_modifyitems(config: "Config", items: "List[Item]") -> None:
     root = Path(__file__).parent.parent
     for item in items:
-        relative = Path(item.fspath).parent.relative_to(root)
-        mark = relative.name
-        item.add_marker(getattr(pytest.mark, mark))
+        if item.fspath:
+            relative = Path(item.fspath).parent.relative_to(root)
+            mark = relative.name
+            item.add_marker(getattr(pytest.mark, mark))
     if not config.getoption("--generate-integration-files"):
         skip_mark = pytest.mark.skip(
             reason="need --generate-integration-files option to run"

tests/unit/test_iocombiner.py

@@ -289,7 +289,7 @@ def test_truncate() -> None:
 
         # truncate at start
         combiner.truncate(0)
-        assert dict(combiner._fileobjs) == {}
+        assert not dict(combiner._fileobjs)
         assert not originals[0].method_calls
 
 

tox.ini

@@ -42,7 +42,7 @@ commands =
     pylint src
     # - pass all files in tests as args because there are no __init__.py
     # - use bash to expend globs https://github.com/tox-dev/tox/issues/1571
-    bash -c "shopt -s globstar; pylint -d duplicate-code,too-many-statements tests/**/*.py"
+    bash -c "shopt -s globstar; pylint -d duplicate-code,too-many-statements,use-implicit-booleaness-not-comparison tests/**/*.py"
 
 [testenv:format]
 skip_install = true