🐛 addresses bug with the window function not behaving correctly

Author: Rohland

package.json

@@ -1,6 +1,6 @@
 {
   "name": "barky",
-  "version": "1.7.6",
+  "version": "1.7.7",
   "description": "A simple cloud services watchdog with digest notification support & no external dependencies",
   "homepage": "https://github.com/Rohland/barky#readme",
   "main": "dist/cli.js",

src/digest/digest.ts

@@ -277,7 +277,7 @@ function evaluateNewFailureResult(
             context.addSnapshotForResult(result);
             break;
         default:
-            throw new Error(`Unhandled rule type: ${ rule.type }`);
+            throw new Error(`Unhandled rule type: ${rule.type}`);
     }
 }
 
@@ -304,7 +304,7 @@ function evaluateNewSuccessResult(
             context.deleteLogs(previousLogs);
             break;
         default:
-            throw new Error(`Unhandled rule type: ${ rule.type }`);
+            throw new Error(`Unhandled rule type: ${rule.type}`);
     }
 }
 

src/evaluators/base.ts

@@ -226,11 +226,15 @@ export abstract class BaseEvaluator {
         if (object) {
             if (isArray) {
                 value = identifier
-                    .map(x => object[x])
+                    // try grab the identifier from the object using both the case provided, and lowercase, as some
+                    // providers (like sumo), seem to randomly lowercase the field name
+                    .map(x => object[x] ?? object[x?.toLowerCase()])
                     .filter(x => x)
                     .join(separator);
             } else {
-                value = object[identifier];
+                // try grab the identifier from the object using both the case provided, and lowercase, as some
+                // providers (like sumo), seem to randomly lowercase the field name
+                value = object[identifier] ?? object[identifier?.toLowerCase()];
             }
             if (typeof value === "string" && value.trim() === "") {
                 value = null;

src/evaluators/sumo.ts

@@ -254,7 +254,7 @@ export class SumoEvaluator extends BaseEvaluator {
             return app._job;
         }
         try {
-            const result = await executeSumoRequest(app.token, () => axios.get(`${SumoLogsUrl}/${app._job}/records?offset=0&limit=100`, getRequestConfig(app.token)));
+            const result = await executeSumoRequest(app.token, () => axios.get(`${SumoLogsUrl}/${app._job}/records?offset=0&limit=1000`, getRequestConfig(app.token)));
             log(`successfully completed sumo job search for '${app.name}', result:`, result.data);
             return result.data;
         } catch (err) {

src/models/alert_configuration.spec.ts

@@ -21,14 +21,18 @@ describe("AlertRule", () => {
         it("should set values and return correct type", () => {
             // arrange
             const config = {
-                any: 1
+                any: 1,
+                window: "-100m"
             } as IAlertRule;
 
             // act
             const rule = new AlertRule(config);
             // assert
             expect(rule.any).toEqual(1);
             expect(rule.type).toEqual(AlertRuleType.AnyInWindow);
+            // we need the window on the object, even though it doesn't appear to be used, because
+            // the type is serialised when a snapshot is taken
+            expect(rule.window).toEqual("-100m");
         });
         describe("with no window defined", () => {
             it("should define window of -5m ", async () => {

src/models/alert_configuration.ts

@@ -41,6 +41,7 @@ export class AlertRule {
     public any?: number;
     public fromDate?: Date;
     public match?: string;
+    public window?: string;
     private _isDefault: boolean;
     private _dayAndTimeEvaluator: DayAndTimeEvaluator;
 
@@ -50,6 +51,7 @@ export class AlertRule {
         this.count = rule.count;
         this.any = rule.any;
         this.match = rule.match;
+        this.window = rule.window;
         const noTypeConfigured = !this.count && !this.any;
         if (noTypeConfigured) {
             this.count = 1;