Walkthrough

Added an optional region field to S3 configuration across model, config dataclass, boto3 session/client/resource usage, tests, and settings; included a Django migration to persist the new region field and a new create_bucket helper that is region-aware.

Changes

Sequence Diagram(s)

(omitted — changes are configuration additions, API client adjustments and a small helper; they do not introduce a new multi-component sequential flow requiring visualization)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 I found a new field where regions play,
I hopped from model to config on my way,
Boto3 now knows which skies to roam,
Tests and fixtures echo it back home,
A tiny leap — S3 finds its way.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

ami/utils/s3.py (1)

103-128: Consider simplifying the duplicated client creation logic.

Both branches pass identical parameters except for endpoint_url. Since the session already contains credentials and region from get_session(), you could simplify this:

♻️ Suggested simplification

 def get_s3_client(config: S3Config) -> S3Client:
     session = get_session(config)
 
     # Always use signature version 4
     boto_config = botocore.config.Config(signature_version="s3v4")
 
-    if config.endpoint_url:
-        client = session.client(
-            service_name="s3",
-            endpoint_url=config.endpoint_url,
-            aws_access_key_id=config.access_key_id,
-            aws_secret_access_key=config.secret_access_key,
-            region_name=config.region,
-            config=boto_config,
-        )
-    else:
-        client = session.client(
-            service_name="s3",
-            aws_access_key_id=config.access_key_id,
-            aws_secret_access_key=config.secret_access_key,
-            region_name=config.region,
-            config=boto_config,
-        )
+    client = session.client(
+        service_name="s3",
+        endpoint_url=config.endpoint_url,  # None is acceptable here
+        config=boto_config,
+    )
 
     client = typing.cast(S3Client, client)
     return client

Note: Re-passing credentials is unnecessary since the session already holds them, and endpoint_url=None is valid (boto3 ignores it).

Configuration used: defaults

Review profile: CHILL

Plan: Pro

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

• X
• Mastodon
• Reddit
• LinkedIn