fix: prepublish protection script removed (migrated to trusted publisher on the npm side)

ci: playwright cache step added

test: timeout increased for the slow github action

Author: Roman86

.github/workflows/publish.yml

@@ -7,6 +7,7 @@ on:
 
 permissions:
   id-token: write
+  contents: read
 
 jobs:
   publish:
@@ -18,14 +19,34 @@ jobs:
           node-version: '20.x'
           registry-url: 'https://registry.npmjs.org'
 
+      - name: Update npm
+        run: npm install -g npm@latest
+
       - name: Install dependencies
         run: npm ci
 
+      - name: Get installed Playwright version
+        id: playwright-version
+        run: echo "version=$(npm ls @playwright/test --json | jq -r '.dependencies["@playwright/test"].version')" >> $GITHUB_OUTPUT
+
+      - name: Cache Playwright browsers
+        uses: actions/cache@v4
+        id: playwright-cache
+        with:
+          path: '~/.cache/ms-playwright'
+          key: ${{ runner.os }}-playwright-${{ steps.playwright-version.outputs.version }}
+          restore-keys: |
+            ${{ runner.os }}-playwright-
+
       - name: Install Playwright browsers
+        if: steps.playwright-cache.outputs.cache-hit != 'true'
         run: npx playwright install --with-deps
 
+      - name: Run Playwright tests
+        run: npm run test
+
       - name: Build
         run: npm run build
 
       - name: Publish
-        run: npm publish --access public
+        run: npm publish

e2e/rowspan.spec.ts

@@ -1,9 +1,9 @@
 import { expect, test } from '@playwright/test';
 
 test('rowspan', async ({ page }, testInfo) => {
-  testInfo?.setTimeout(2000);
-  page.setDefaultNavigationTimeout(1000);
-  page.setDefaultTimeout(100);
+  testInfo?.setTimeout(10000);
+  page.setDefaultNavigationTimeout(5000);
+  page.setDefaultTimeout(1000);
 
   await page.goto('/');
 
@@ -25,24 +25,28 @@ test('rowspan', async ({ page }, testInfo) => {
     },
   };
 
-  for (const [
-    selector,
-    validator,
-  ] of Object.entries(cases)) {
-    const elements = await page.locator(selector).filter({ visible: true }).all();
+  for (const [selector, validator] of Object.entries(cases)) {
+    const elements = await page
+      .locator(selector)
+      .filter({ visible: true })
+      .all();
     for await (const el of elements) {
       const box = await el.boundingBox();
       const targetHeight = validator.height;
       const actualHeight = box?.height;
       const heightError =
-        targetHeight != null && actualHeight != null && Math.abs(targetHeight - actualHeight) > 10
+        targetHeight != null &&
+        actualHeight != null &&
+        Math.abs(targetHeight - actualHeight) > 10
           ? `Bad height: expected around ${targetHeight}px, actual ${actualHeight}px`
           : undefined;
 
       const targetTop = validator.top;
       const actualTop = box?.y;
       const topError =
-        targetTop != null && actualTop != null && Math.abs(targetTop - actualTop) > 10
+        targetTop != null &&
+        actualTop != null &&
+        Math.abs(targetTop - actualTop) > 10
           ? `Bad top position: expected around ${targetTop}px, actual ${actualTop}px`
           : undefined;
 

e2e/utils.ts

@@ -1,21 +1,22 @@
-import { Locator, Page, TestInfo } from '@playwright/test';
+import type { Locator, Page, TestInfo } from '@playwright/test';
 
 interface TestScenario {
   url: string;
   rules: Record<string, (locator: Locator) => Promise<void>>;
 }
 
-export async function testTheScenario(scenario: TestScenario, page: Page, testInfo?: TestInfo) {
-  testInfo?.setTimeout(2000);
+export async function testTheScenario(
+  scenario: TestScenario,
+  page: Page,
+  testInfo?: TestInfo,
+) {
+  testInfo?.setTimeout(10000);
   page.setDefaultNavigationTimeout(1000);
   page.setDefaultTimeout(100);
 
   await page.goto(scenario.url);
 
-  for (const [
-    selector,
-    validator,
-  ] of Object.entries(scenario.rules)) {
+  for (const [selector, validator] of Object.entries(scenario.rules)) {
     await validator(page.locator(selector));
   }
 }

package.json

@@ -18,7 +18,6 @@
     "dist"
   ],
   "scripts": {
-    "prepublishOnly": "npm run lint && npm run test && npm run build && git diff --exit-code --quiet || { echo \"Git working directory is not clean. Please commit or stash your changes.\"; exit 1; }",
     "build": "tsup src/index.ts --format cjs,esm --dts --minify --clean",
     "lint": "biome lint ./src",
     "format": "biome format --write ./src",