WAU script hardening

Author: FaserF

Sources/Winget-AutoUpdate/WAU-Installer-GUI.ps1

@@ -381,7 +381,7 @@ Add-Type -AssemblyName PresentationFramework
 Start-PopUp "Starting..."
 
 #Set config
-$null = cmd /c ''
+$null = & "$env:WINDIR\System32\cmd.exe" /c ""
 [Console]::OutputEncoding = [System.Text.Encoding]::UTF8
 $Script:ProgressPreference = "SilentlyContinue"
 $Script:ErrorActionPreference = "SilentlyContinue"

Sources/Winget-AutoUpdate/Winget-Upgrade.ps1

@@ -9,7 +9,7 @@ Get-ChildItem -Path "$($Script:WorkingDir)\functions" -File -Filter "*.ps1" -Dep
 <# MAIN #>
 
 # Config console output encoding
-$null = cmd /c '';
+$null = & "$env:WINDIR\System32\cmd.exe" /c ""
 [Console]::OutputEncoding = [System.Text.Encoding]::UTF8;
 $Script:ProgressPreference = [System.Management.Automation.ActionPreference]::SilentlyContinue;
 

Sources/Winget-AutoUpdate/functions/Get-WingetOutdatedApps.ps1

@@ -2,11 +2,11 @@
 
 function Get-WingetOutdatedApps {
 
-Param(
-    [Parameter(Position=0,Mandatory=$True,HelpMessage="You MUST supply value for winget repo, we need it")]
-    [ValidateNotNullorEmpty()]
-    [string]$src
-)
+    Param(
+        [Parameter(Position = 0, Mandatory = $True, HelpMessage = "You MUST supply value for winget repo, we need it")]
+        [ValidateNotNullorEmpty()]
+        [string]$src
+    )
     class Software {
         [string]$Name
         [string]$Id
@@ -15,7 +15,13 @@ Param(
     }
 
     #Get list of available upgrades on winget format
-    $upgradeResult = & $Winget upgrade --source $src | Where-Object { $_ -notlike "   *" } | Out-String
+    try {
+        $upgradeResult = & $Winget upgrade --source $src | Where-Object { $_ -notlike "   *" } | Out-String
+    }
+    catch {
+        Write-ToLog "Error while recieving winget upgrade list: $_" "Red"
+        $upgradeResult = $null
+    }
 
     #Start Conversion of winget format to an array. Check if "-----" exists (Winget Error Handling)
     if (!($upgradeResult -match "-----")) {

Sources/Winget-AutoUpdate/functions/Test-Network.ps1

@@ -32,8 +32,15 @@ function Test-Network {
             Write-ToLog "Connected !" "Green"
 
             #Check for metered connection
-            [void][Windows.Networking.Connectivity.NetworkInformation, Windows, ContentType = WindowsRuntime]
-            $cost = [Windows.Networking.Connectivity.NetworkInformation]::GetInternetConnectionProfile().GetConnectionCost()
+            try {
+                Add-Type -AssemblyName 'Windows.Networking, ContentType=WindowsRuntime' -ErrorAction Stop
+                #[void][Windows.Networking.Connectivity.NetworkInformation, Windows, ContentType = WindowsRuntime]
+                $cost = [Windows.Networking.Connectivity.NetworkInformation]::GetInternetConnectionProfile().GetConnectionCost()
+            }
+            catch {
+                Write-ToLog "Could not evaluate metered connection status - skipping check." "Gray"
+                return $true
+            }
 
             if ($cost.ApproachingDataLimit -or $cost.OverDataLimit -or $cost.Roaming -or $cost.BackgroundDataUsageRestricted -or ($cost.NetworkCostType -ne "Unrestricted")) {