Skip to content

Commit 0302e16

Browse files
committed
fix: improve Gemini model configuration consistency
- Fix inconsistent logic in CodeIndexSettings where Gemini was incorrectly included in OpenAI model fallback - Add clarifying comment for hardcoded Gemini embedding dimension (768) in service-factory
1 parent dfc844e commit 0302e16

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/services/code-index/service-factory.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export class CodeIndexServiceFactory {
8585
vectorSize = getModelDimension(provider, modelId)
8686
}
8787
} else if (provider === "gemini") {
88-
// Gemini has a fixed dimension of 768
88+
// Gemini's text-embedding-004 has a fixed dimension of 768
8989
vectorSize = 768
9090
} else {
9191
vectorSize = getModelDimension(provider, modelId)

webview-ui/src/components/settings/CodeIndexSettings.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,11 @@ export const CodeIndexSettings: React.FC<CodeIndexSettingsProps> = ({
6363
// Safely calculate available models for current provider
6464
const currentProvider = codebaseIndexConfig?.codebaseIndexEmbedderProvider
6565
const modelsForProvider =
66-
currentProvider === "openai" ||
67-
currentProvider === "ollama" ||
68-
currentProvider === "openai-compatible" ||
6966
currentProvider === "gemini"
70-
? codebaseIndexModels?.[currentProvider] || codebaseIndexModels?.openai
71-
: codebaseIndexModels?.openai
67+
? undefined // or an empty array, since Gemini has a fixed model
68+
: currentProvider === "openai" || currentProvider === "openai-compatible"
69+
? (codebaseIndexModels?.openai ?? codebaseIndexModels?.["openai-compatible"])
70+
: codebaseIndexModels?.[currentProvider as keyof typeof codebaseIndexModels]
7271
const availableModelIds = Object.keys(modelsForProvider || {})
7372

7473
useEffect(() => {

0 commit comments

Comments
 (0)