fix: Resolve path space escaping and add missing path-browserify dependency

- Refined space escaping logic in `context-mentions.ts` and `path-mentions.ts` to handle potential edge cases and improve robustness, addressing concerns about escaped characters.
- Added `path-browserify` and `@types/path-browserify` to `webview-ui/package.json` to resolve missing dependency and type errors.

Author: Yikai-Liao

webview-ui/package-lock.json

@@ -45,6 +45,7 @@
 		"knuth-shuffle-seeded": "^1.0.6",
 		"lucide-react": "^0.475.0",
 		"mermaid": "^11.4.1",
+		"path-browserify": "^1.0.1",
 		"posthog-js": "^1.227.2",
 		"react": "^18.3.1",
 		"react-dom": "^18.3.1",
@@ -75,6 +76,7 @@
 		"@testing-library/user-event": "^14.6.1",
 		"@types/jest": "^27.5.2",
 		"@types/node": "^18.0.0",
+		"@types/path-browserify": "^1.0.2",
 		"@types/react": "^18.3.18",
 		"@types/react-dom": "^18.3.5",
 		"@types/shell-quote": "^1.7.5",

webview-ui/package.json

@@ -65,9 +65,11 @@ export function insertMention(
 	 */
 	// Escape spaces, handling already escaped spaces
 	const formattedValue = value
+		.replace(/\\\\/g, "\\DOUBLE_BACKSLASH") // First preserve actual double backslashes
 		.replace(/\\ /g, "\\ESCAPED_SPACE") // Temporarily replace already escaped spaces
 		.replace(/ /g, "\\ ") // Escape all normal spaces
 		.replace(/\\ESCAPED_SPACE/g, "\\\\ ") // Restore escaped spaces with proper escaping
+		.replace(/\\DOUBLE_BACKSLASH/g, "\\\\") // Restore actual double backslashes
 
 	if (lastAtIndex !== -1) {
 		// If there's an '@' symbol, replace text after it up to the next space/end

webview-ui/src/utils/context-mentions.ts

@@ -12,32 +12,28 @@
  * @returns A mention-friendly path
  */
 export function convertToMentionPath(path: string, cwd?: string): string {
-	// First, detect and temporarily replace already escaped spaces
-	// We need to be careful with Windows paths that use backslashes
-	const detectedPath = path.replace(/\\/g, "/")
-	// Temporarily replace escaped spaces
-	let processedPath = detectedPath.replace(/\\ /g, "\\ESCAPED_SPACE")
-
-	let normalizedCwd = cwd ? cwd.replace(/\\/g, "/") : ""
+	// First, handle Windows path separators and convert to forward slashes
+	let processedPath = path.replace(/\\\\/g, "//").replace(/\\/g, "/");
+	let normalizedCwd = cwd ? cwd.replace(/\\\\/g, "//").replace(/\\/g, "/") : "";
 
 	if (!normalizedCwd) {
-		// If no CWD, just escape spaces in the original path and restore escaped spaces
-		return processedPath.replace(/ /g, "\\ ").replace(/\\ESCAPED_SPACE/g, "\\\\ ")
+		// If no CWD, just escape spaces in the original path
+		return processedPath.replace(/ /g, "\\ ");
 	}
 
 	// Remove trailing slash from cwd if it exists
 	if (normalizedCwd.endsWith("/")) {
-		normalizedCwd = normalizedCwd.slice(0, -1)
+		normalizedCwd = normalizedCwd.slice(0, -1);
 	}
 
 	// Always use case-insensitive comparison for path matching
-	const lowerPath = processedPath.toLowerCase()
-	const lowerCwd = normalizedCwd.toLowerCase()
+	const lowerPath = processedPath.toLowerCase();
+	const lowerCwd = normalizedCwd.toLowerCase();
 
 	if (lowerPath.startsWith(lowerCwd)) {
-		const relativePath = processedPath.substring(normalizedCwd.length)
+		const relativePath = processedPath.substring(normalizedCwd.length);
 		// Ensure there's a slash after the @ symbol when we create the mention path
-		let mentionPath = "@" + (relativePath.startsWith("/") ? relativePath : "/" + relativePath)
+		let mentionPath = "@" + (relativePath.startsWith("/") ? relativePath : "/" + relativePath);
 
 		/**
 		 * Space escaping logic for file paths
@@ -57,10 +53,10 @@ export function convertToMentionPath(path: string, cwd?: string): string {
 		 * will undergo a second round of escaping, resulting in double backslashes.
 		 * This is necessary to preserve the escapes through the entire text processing pipeline.
 		 */
-		// Escape regular spaces and restore already escaped spaces
-		return mentionPath.replace(/ /g, "\\ ").replace(/\\ESCAPED_SPACE/g, "\\\\ ")
+		// Escape spaces
+		return mentionPath.replace(/ /g, "\\ ");
 	}
 
 	// If path doesn't start with CWD, escape spaces in the processed path
-	return processedPath.replace(/ /g, "\\ ").replace(/\\ESCAPED_SPACE/g, "\\\\ ")
+	return processedPath.replace(/ /g, "\\ ");
 }