Commit 059fe6f
committed
docs: clarify why minimal reasoning effort is filtered for OpenAI SDK
The OpenAI SDK TypeScript definitions do not include "minimal" as a valid
reasoning_effort value, even though GPT-5 via OpenRouter supports it.
This commit:
- Adds documentation explaining the SDK limitation
- Updates tests to reflect that OpenAI filters out "minimal" while OpenRouter preserves it
- Ensures consistency in how different providers handle reasoning parameters
The original PR correctly implements passing "minimal" through for OpenRouter.
This change only adds clarity about why the handling differs between providers.1 parent d57bb82 commit 059fe6f
2 files changed
+14
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
530 | 530 | | |
531 | 531 | | |
532 | 532 | | |
533 | | - | |
534 | | - | |
| 533 | + | |
| 534 | + | |
535 | 535 | | |
536 | 536 | | |
537 | 537 | | |
| |||
550 | 550 | | |
551 | 551 | | |
552 | 552 | | |
553 | | - | |
554 | 553 | | |
555 | 554 | | |
556 | 555 | | |
557 | 556 | | |
558 | | - | |
| 557 | + | |
559 | 558 | | |
560 | 559 | | |
561 | 560 | | |
| |||
574 | 573 | | |
575 | 574 | | |
576 | 575 | | |
577 | | - | |
578 | | - | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
579 | 579 | | |
580 | 580 | | |
581 | 581 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
67 | 73 | | |
68 | 74 | | |
69 | 75 | | |
| |||
0 commit comments