fix(settings): address PR review feedback for custom max tokens feature

- Simplify MaxTokensControl component by removing redundant fallback pattern

- Update UI to show model's actual max tokens as default instead of hardcoded 8192

- Add validation in getModelMaxOutputTokens to cap user values to model's max

- Add test case for validation when user sets higher than model's max

- Update existing tests to expect capped values

Addresses review feedback from daniel-lxs on PR #5788

Author: MuriloFP

src/shared/__tests__/api.spec.ts

@@ -73,7 +73,8 @@ describe("getModelMaxOutputTokens", () => {
 			settings,
 		})
 
-		expect(result).toBe(32000)
+		// Should cap to model's maxTokens (8192) even though user set 32000
+		expect(result).toBe(8192)
 	})
 
 	test("should return default of 8192 when maxTokens is undefined", () => {
@@ -166,7 +167,8 @@ describe("getModelMaxOutputTokens", () => {
 			settings,
 		})
 
-		expect(result).toBe(16000)
+		// Should cap to model's maxTokens (8192) even though user set 16000
+		expect(result).toBe(8192)
 	})
 
 	test("should ignore modelMaxTokens when it's 0 or negative", () => {
@@ -216,7 +218,29 @@ describe("getModelMaxOutputTokens", () => {
 			format: "anthropic",
 		})
 
-		expect(result).toBe(20000)
+		// Should cap to model's maxTokens (8192) even though user set 20000
+		expect(result).toBe(8192)
+	})
+
+	test("should cap modelMaxTokens to model's actual max when user sets higher value", () => {
+		const model: ModelInfo = {
+			maxTokens: 16000,
+			contextWindow: 100000,
+			supportsPromptCache: true,
+		}
+
+		const settings: ProviderSettings = {
+			modelMaxTokens: 32000, // Higher than model's max
+		}
+
+		const result = getModelMaxOutputTokens({
+			modelId: "some-model",
+			model,
+			settings,
+		})
+
+		// Should cap at model's max
+		expect(result).toBe(16000)
 	})
 })
 

src/shared/api.ts

@@ -70,9 +70,10 @@ export const getModelMaxOutputTokens = ({
 		return settings.claudeCodeMaxOutputTokens || CLAUDE_CODE_DEFAULT_MAX_OUTPUT_TOKENS
 	}
 
-	// Check for user-configured modelMaxTokens
+	// Check for user-configured modelMaxTokens (takes precedence over all other logic)
 	if (settings?.modelMaxTokens && settings.modelMaxTokens > 0) {
-		return settings.modelMaxTokens
+		const maxAllowed = model?.maxTokens || Number.MAX_SAFE_INTEGER
+		return Math.min(settings.modelMaxTokens, maxAllowed)
 	}
 
 	// Existing reasoning budget logic

webview-ui/src/components/settings/MaxTokensControl.tsx

@@ -17,7 +17,7 @@ export const MaxTokensControl: React.FC<MaxTokensControlProps> = ({
 	onChange,
 	modelInfo,
 	minValue = 1000,
-	maxValue = 200000,
+	maxValue,
 	className,
 }) => {
 	const { t } = useAppTranslation()
@@ -35,8 +35,8 @@ export const MaxTokensControl: React.FC<MaxTokensControlProps> = ({
 		}
 	}
 
-	const effectiveMaxValue = modelInfo?.maxTokens || maxValue
-	const displayValue = value ?? 8192
+	const effectiveMaxValue = modelInfo?.maxTokens || maxValue || 100000
+	const displayValue = value ?? modelInfo?.maxTokens ?? 8192
 
 	const isValueTooHigh = displayValue > effectiveMaxValue
 	const isValueTooLow = displayValue < minValue