Skip to content

Commit 0b9010a

Browse files
authored
Remove event types mention from PR reviewer rules (#6428)
1 parent 14a116e commit 0b9010a

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

.roo/rules-pr-reviewer/1_workflow.xml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@
387387
{
388388
"commit_id": "[headRefOid from Step 2]",
389389
"body": "Thank you for your contribution! I've reviewed the changes and [found issues that need attention / have some suggestions for improvement].",
390-
"event": "[COMMENT|REQUEST_CHANGES|APPROVE]",
390+
"event": "COMMENT",
391391
"comments": [
392392
{
393393
"path": "[file/path/to/code.ts]",
@@ -402,18 +402,13 @@ EOF</command>
402402

403403
The review will be created with all inline comments attached to specific lines of code.
404404

405-
Note on event types:
406-
- "COMMENT": Submit general feedback without approval/rejection
407-
- "REQUEST_CHANGES": Request changes be made before merging
408-
- "APPROVE": Approve the PR for merging
409-
410-
Example for a review requesting changes:
405+
Example for a review:
411406
<execute_command>
412407
<command>gh api -X POST repos/RooCodeInc/Roo-Code/pulls/6378/reviews --input - <<EOF
413408
{
414409
"commit_id": "abc123def4567890...",
415410
"body": "Thank you for your contribution! I've reviewed the changes and found that the critical issues from the previous review are still pending. I've left some suggestions inline to help improve the implementation.",
416-
"event": "REQUEST_CHANGES",
411+
"event": "COMMENT",
417412
"comments": [
418413
{
419414
"path": "packages/cloud/src/CloudService.ts",

.roo/rules-pr-reviewer/2_best_practices.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
- Use the GitHub API for submitting reviews to support inline comments
3232
- Construct proper JSON payloads with commit_id, body, event, and comments array
3333
- Each inline comment needs: path, body, line number, and side (RIGHT for new code)
34-
- Choose appropriate review event: COMMENT, REQUEST_CHANGES, or APPROVE
34+
- Use COMMENT when submitting the review
3535
- Use heredoc syntax (--input - <<EOF) to pass JSON directly
3636
- Offer the option to create individual tasks for each suggestion
3737
- When creating tasks, choose the appropriate mode for each type of work

.roo/rules-pr-reviewer/3_common_mistakes_to_avoid.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
- Forgetting to specify "side": "RIGHT" for comments on new code
3535
- Using incorrect line numbers that don't match the actual diff
3636
- Not escaping special characters in JSON payload properly
37-
- Using wrong event type (e.g., REQUEST_CHANGES when only commenting)
37+
- Not using COMMENT as the event type in the review payload
3838
- Not constructing proper file paths relative to repository root
3939
- Submitting empty comments array when inline comments are needed
4040
- Forgetting to use <<EOF syntax properly in the command

0 commit comments

Comments
 (0)