Skip to content

Commit 0bb6112

Browse files
committed
fix: ensure disabled MCP servers appear in settings UI
When the MCP server was initialized before opening RooCode, disabled servers would not appear in the settings UI. This was fixed by: 1. Using getAllServers() instead of getServers() in ClineProvider.ts for UI state updates, ensuring all servers (including disabled ones) are shown 2. Maintaining getServers() for operational use (AI prompts, tool calls) where disabled servers should be filtered out The fix maintains clean separation between UI display and operational server filtering.
1 parent c6c70c2 commit 0bb6112

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/core/webview/ClineProvider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ export class ClineProvider implements vscode.WebviewViewProvider {
628628
if (this.mcpHub) {
629629
this.postMessageToWebview({
630630
type: "mcpServers",
631-
mcpServers: this.mcpHub.getServers(),
631+
mcpServers: this.mcpHub.getAllServers(),
632632
})
633633
}
634634

@@ -2259,7 +2259,7 @@ export class ClineProvider implements vscode.WebviewViewProvider {
22592259
autoApprovalEnabled: autoApprovalEnabled ?? false,
22602260
customModes: await this.customModesManager.getCustomModes(),
22612261
experiments: experiments ?? experimentDefault,
2262-
mcpServers: this.mcpHub?.getServers() ?? [],
2262+
mcpServers: this.mcpHub?.getAllServers() ?? [],
22632263
}
22642264
}
22652265

src/services/mcp/McpHub.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,11 @@ export class McpHub {
6767
return this.connections.filter((conn) => !conn.server.disabled).map((conn) => conn.server)
6868
}
6969

70+
getAllServers(): McpServer[] {
71+
// Return all servers regardless of state
72+
return this.connections.map((conn) => conn.server)
73+
}
74+
7075
async getMcpServersPath(): Promise<string> {
7176
const provider = this.providerRef.deref()
7277
if (!provider) {

0 commit comments

Comments
 (0)