refactor(webview): make handleDismiss synchronous in DismissibleUpsell

test(webview): add scenario where dismissOnClick=true without onClick tracks only UPSELL_DISMISSED; update tests; all tests passing locally

Author: roomote

webview-ui/src/components/common/DismissibleUpsell.tsx

@@ -78,7 +78,7 @@ const DismissibleUpsell = memo(
 			}
 		}, [upsellId])
 
-		const handleDismiss = async () => {
+		const handleDismiss = () => {
 			// Track telemetry for dismissal
 			telemetryClient.capture(TelemetryEventName.UPSELL_DISMISSED, {
 				upsellId: upsellId,

webview-ui/src/components/common/__tests__/DismissibleUpsell.spec.tsx

@@ -531,6 +531,46 @@ describe("DismissibleUpsell", () => {
 		})
 	})
 
+	it("dismisses on container click when dismissOnClick is true and no onClick is provided; tracks only dismissal", async () => {
+		const onDismiss = vi.fn()
+		const { container } = render(
+			<DismissibleUpsell upsellId="test-upsell" onDismiss={onDismiss} dismissOnClick={true}>
+				<div>Test content</div>
+			</DismissibleUpsell>,
+		)
+
+		// Make component visible
+		makeUpsellVisible()
+
+		// Wait for component to be visible
+		await waitFor(() => {
+			expect(screen.getByText("Test content")).toBeInTheDocument()
+		})
+
+		// Click on the container (not the dismiss button)
+		const containerDiv = screen.getByText("Test content").parentElement as HTMLElement
+		fireEvent.click(containerDiv)
+
+		// onDismiss should be called
+		expect(onDismiss).toHaveBeenCalledTimes(1)
+
+		// Telemetry: only dismissal should be tracked
+		expect(mockCapture).toHaveBeenCalledWith(TelemetryEventName.UPSELL_DISMISSED, {
+			upsellId: "test-upsell",
+		})
+		expect(mockCapture).not.toHaveBeenCalledWith(TelemetryEventName.UPSELL_CLICKED, expect.anything())
+
+		// Dismiss message should be sent
+		expect(mockPostMessage).toHaveBeenCalledWith({
+			type: "dismissUpsell",
+			upsellId: "test-upsell",
+		})
+
+		// Component should be hidden
+		await waitFor(() => {
+			expect(container.firstChild).toBeNull()
+		})
+	})
 	it("does not dismiss when clicked if dismissOnClick is false", async () => {
 		const onClick = vi.fn()
 		const onDismiss = vi.fn()