Add Expirement Toggle for VS Code LM Function Calling Feature

Author: shannonlal

src/core/Cline.ts

@@ -63,7 +63,7 @@ import { OpenRouterHandler } from "../api/providers/openrouter"
 import { McpHub } from "../services/mcp/McpHub"
 import crypto from "crypto"
 import { insertGroups } from "./diff/insert-groups"
-import { EXPERIMENT_IDS, experiments as Experiments } from "../shared/experiments"
+import { EXPERIMENT_IDS, experiments as Experiments, experimentDefault } from "../shared/experiments"
 
 const cwd =
 	vscode.workspace.workspaceFolders?.map((folder) => folder.uri.fsPath).at(0) ?? path.join(os.homedir(), "Desktop") // may or may not exist but fs checking existence would immediately ask for permission which would be bad UX, need to come up with a better solution
@@ -1263,6 +1263,7 @@ export class Cline {
 				// Validate tool use before execution
 				const { mode, customModes } = (await this.providerRef.deref()?.getState()) ?? {}
 				try {
+					const { experiments } = (await this.providerRef.deref()?.getState()) ?? {}
 					validateToolUse(
 						block.name as ToolName,
 						mode ?? defaultModeSlug,
@@ -1271,6 +1272,7 @@ export class Cline {
 							apply_diff: this.diffEnabled,
 						},
 						block.params,
+						experiments,
 					)
 				} catch (error) {
 					this.consecutiveMistakeCount++
@@ -2513,14 +2515,22 @@ export class Cline {
 							break
 						}
 					}
-
 					case "list_vscode_lm_tools": {
 						try {
-							// Get all registered VS Code LM tools
-							const tools = vscode.lm.tools
+							// Check if experiment is enabled
+							const { experiments = experimentDefault } =
+								(await this.providerRef.deref()?.getState()) ?? {}
+							if (!Experiments.isEnabled(experiments, EXPERIMENT_IDS.VSCODE_LM_TOOLS)) {
+								pushToolResult(
+									formatResponse.toolError(
+										"VSCode LM Tools experiment is not enabled. Enable it in Settings > Advanced Settings > Experimental Features.",
+									),
+								)
+								break
+							}
 
 							// Format tool information
-							const toolsList = tools.map((tool) => ({
+							const toolsList = vscode.lm.tools.map((tool) => ({
 								name: tool.name,
 								description: tool.description,
 								inputSchema: tool.inputSchema,
@@ -2551,6 +2561,18 @@ export class Cline {
 						const arguments_str: string | undefined = block.params.arguments
 
 						try {
+							// Check if experiment is enabled
+							const { experiments = experimentDefault } =
+								(await this.providerRef.deref()?.getState()) ?? {}
+							if (!Experiments.isEnabled(experiments, EXPERIMENT_IDS.VSCODE_LM_TOOLS)) {
+								pushToolResult(
+									formatResponse.toolError(
+										"VSCode LM Tools experiment is not enabled. Enable it in Settings > Advanced Settings > Experimental Features.",
+									),
+								)
+								break
+							}
+
 							if (block.partial) {
 								const partialMessage = JSON.stringify({
 									tool: "callVsCodeLmTool",

src/core/mode-validator.ts

@@ -10,8 +10,9 @@ export function validateToolUse(
 	customModes?: ModeConfig[],
 	toolRequirements?: Record<string, boolean>,
 	toolParams?: Record<string, unknown>,
+	experiments?: Record<string, boolean>,
 ): void {
-	if (!isToolAllowedForMode(toolName, mode, customModes ?? [], toolRequirements, toolParams)) {
+	if (!isToolAllowedForMode(toolName, mode, customModes ?? [], toolRequirements, toolParams, experiments)) {
 		throw new Error(`Tool "${toolName}" is not allowed in ${mode} mode.`)
 	}
 }

src/shared/experiments.ts

@@ -2,6 +2,7 @@ export const EXPERIMENT_IDS = {
 	DIFF_STRATEGY: "experimentalDiffStrategy",
 	SEARCH_AND_REPLACE: "search_and_replace",
 	INSERT_BLOCK: "insert_content",
+	VSCODE_LM_TOOLS: "vscodeLmTools",
 } as const
 
 export type ExperimentKey = keyof typeof EXPERIMENT_IDS
@@ -30,11 +31,16 @@ export const experimentConfigsMap: Record<ExperimentKey, ExperimentConfig> = {
 	},
 	INSERT_BLOCK: {
 		name: "Use experimental insert content tool",
-
 		description:
 			"Enable the experimental insert content tool, allowing Roo to insert content at specific line numbers without needing to create a diff.",
 		enabled: false,
 	},
+	VSCODE_LM_TOOLS: {
+		name: "Use VSCode Language Model Tools",
+		description:
+			"Enable integration with VSCode's language model tools. This allows Roo to list and invoke VSCode's built-in AI capabilities.",
+		enabled: false,
+	},
 }
 
 export const experimentDefault = Object.fromEntries(

src/shared/modes.ts

@@ -83,7 +83,13 @@ export const modes: readonly ModeConfig[] = [
 		name: "Architect",
 		roleDefinition:
 			"You are Roo, an experienced technical leader who is inquisitive and an excellent planner. Your goal is to gather information and get context to create a detailed plan for accomplishing the user's task, which the user will review and approve before they switch into another mode to implement the solution.",
-		groups: ["read", ["edit", { fileRegex: "\\.md$", description: "Markdown files only" }], "browser", "mcp", "vscode_lm"],
+		groups: [
+			"read",
+			["edit", { fileRegex: "\\.md$", description: "Markdown files only" }],
+			"browser",
+			"mcp",
+			"vscode_lm",
+		],
 		customInstructions:
 			"Depending on the user's request, you may need to do some information gathering (for example using read_file or search_files) to get more context about the task. You may also ask the user clarifying questions to get a better understanding of the task. Once you've gained more context about the user's request, you should create a detailed plan for how to accomplish the task. (You can write the plan to a markdown file if it seems appropriate.)\n\nThen you might ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it. Finally once it seems like you've reached a good plan, use the switch_mode tool to request that the user switch to another mode to implement the solution.",
 	},
@@ -92,7 +98,13 @@ export const modes: readonly ModeConfig[] = [
 		name: "Ask",
 		roleDefinition:
 			"You are Roo, a knowledgeable technical assistant focused on answering questions and providing information about software development, technology, and related topics.",
-		groups: ["read", "browser", "mcp", "vscode_lm"],
+		groups: [
+			"read",
+			["edit", { fileRegex: "\\.md$", description: "Markdown files only" }],
+			"browser",
+			"mcp",
+			"vscode_lm",
+		],
 		customInstructions:
 			"You can analyze code, explain concepts, and access external resources. Make sure to answer the user's questions and don't rush to switch to implementing code.",
 	},
@@ -202,6 +214,13 @@ export function isToolAllowedForMode(
 			continue
 		}
 
+		// Check if group requires an experiment to be enabled
+		if (groupConfig.requireExperiment && experiments) {
+			if (!experiments[groupConfig.requireExperiment]) {
+				continue
+			}
+		}
+
 		// If there are no options, allow the tool
 		if (!options) {
 			return true

src/shared/tool-groups.ts

@@ -2,6 +2,7 @@
 export type ToolGroupConfig = {
 	tools: readonly string[]
 	alwaysAvailable?: boolean // Whether this group is always available and shouldn't show in prompts view
+	requireExperiment?: string // Experiment ID that must be enabled for this group to be available
 }
 
 // Map of tool slugs to their display names
@@ -47,6 +48,7 @@ export const TOOL_GROUPS: Record<string, ToolGroupConfig> = {
 	},
 	vscode_lm: {
 		tools: ["list_vscode_lm_tools", "call_vscode_lm_tool"],
+		requireExperiment: "vscodeLmTools",
 	},
 }