Skip to content

Commit 12676a1

Browse files
committed
fix: remove on_disk settings from Qdrant configuration to fix Windows 11 crash
The on_disk: true settings added in v3.26.1 were causing the extension host to crash on Windows 11 with VS Code Insiders. This commit removes these settings from both the vector store implementation and its tests. Fixes #7482
1 parent 548d3b4 commit 12676a1

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

src/services/code-index/vector-store/__tests__/qdrant-client.spec.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -532,12 +532,10 @@ describe("QdrantVectorStore", () => {
532532
vectors: {
533533
size: mockVectorSize,
534534
distance: "Cosine", // Assuming 'Cosine' is the DISTANCE_METRIC
535-
on_disk: true,
536535
},
537536
hnsw_config: {
538537
m: 64,
539538
ef_construct: 512,
540-
on_disk: true,
541539
},
542540
})
543541
expect(mockQdrantClientInstance.deleteCollection).not.toHaveBeenCalled()
@@ -616,12 +614,10 @@ describe("QdrantVectorStore", () => {
616614
vectors: {
617615
size: mockVectorSize, // Should use the new, correct vector size
618616
distance: "Cosine",
619-
on_disk: true,
620617
},
621618
hnsw_config: {
622619
m: 64,
623620
ef_construct: 512,
624-
on_disk: true,
625621
},
626622
})
627623

@@ -915,12 +911,10 @@ describe("QdrantVectorStore", () => {
915911
vectors: {
916912
size: newVectorSize, // Should create with new 768 dimensions
917913
distance: "Cosine",
918-
on_disk: true,
919914
},
920915
hnsw_config: {
921916
m: 64,
922917
ef_construct: 512,
923-
on_disk: true,
924918
},
925919
})
926920
expect(mockQdrantClientInstance.createPayloadIndex).toHaveBeenCalledTimes(5)

src/services/code-index/vector-store/qdrant-client.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,12 +155,10 @@ export class QdrantVectorStore implements IVectorStore {
155155
vectors: {
156156
size: this.vectorSize,
157157
distance: this.DISTANCE_METRIC,
158-
on_disk: true,
159158
},
160159
hnsw_config: {
161160
m: 64,
162161
ef_construct: 512,
163-
on_disk: true,
164162
},
165163
})
166164
created = true
@@ -250,12 +248,10 @@ export class QdrantVectorStore implements IVectorStore {
250248
vectors: {
251249
size: this.vectorSize,
252250
distance: this.DISTANCE_METRIC,
253-
on_disk: true,
254251
},
255252
hnsw_config: {
256253
m: 64,
257254
ef_construct: 512,
258-
on_disk: true,
259255
},
260256
})
261257
console.log(`[QdrantVectorStore] Successfully created new collection ${this.collectionName}`)

0 commit comments

Comments
 (0)