Remove unused codeBlocks from scanner interface and implementation

- Remove codeBlocks property from IDirectoryScanner interface
- Update scanner implementation to not return codeBlocks
- Update tests to remove codeBlocks assertions
- This completes the memory optimization by eliminating the unused return value

The scanner now only returns stats and totalBlockCount, which are the only
values actually used by the orchestrator. This further reduces memory usage
and simplifies the interface.

Author: daniel-lxs

src/services/code-index/interfaces/file-processor.ts

@@ -38,7 +38,6 @@ export interface IDirectoryScanner {
 		onBlocksIndexed?: (indexedCount: number) => void,
 		onFileParsed?: (fileBlockCount: number) => void,
 	): Promise<{
-		codeBlocks: CodeBlock[]
 		stats: {
 			processed: number
 			skipped: number

src/services/code-index/processors/__tests__/scanner.spec.ts

@@ -195,7 +195,6 @@ describe("DirectoryScanner", () => {
 			;(mockCodeParser.parseFile as any).mockResolvedValue(mockBlocks)
 
 			const result = await scannerNoEmbeddings.scanDirectory("/test")
-			expect(result.codeBlocks).toEqual([]) // Now returns empty array for memory optimization
 			expect(result.stats.processed).toBe(1)
 		})
 
@@ -332,9 +331,7 @@ describe("DirectoryScanner", () => {
 			expect(mockCodeParser.parseFile).toHaveBeenCalledWith("test/app.js", expect.any(Object))
 			expect(mockCodeParser.parseFile).toHaveBeenCalledWith("docs/guide.markdown", expect.any(Object))
 
-			// Verify codeBlocks is empty (memory optimization) but processing still works
-			expect(result.codeBlocks).toEqual([])
-
+			// Verify processing still works without codeBlocks accumulation
 			expect(result.stats.processed).toBe(3)
 		})
 

src/services/code-index/processors/scanner.ts

@@ -51,7 +51,7 @@ export class DirectoryScanner implements IDirectoryScanner {
 		onError?: (error: Error) => void,
 		onBlocksIndexed?: (indexedCount: number) => void,
 		onFileParsed?: (fileBlockCount: number) => void,
-	): Promise<{ codeBlocks: CodeBlock[]; stats: { processed: number; skipped: number }; totalBlockCount: number }> {
+	): Promise<{ stats: { processed: number; skipped: number }; totalBlockCount: number }> {
 		const directoryPath = directory
 		// Capture workspace context at scan start
 		const scanWorkspace = getWorkspacePathForContext(directoryPath)
@@ -279,7 +279,6 @@ export class DirectoryScanner implements IDirectoryScanner {
 		}
 
 		return {
-			codeBlocks: [], // Return empty array to prevent memory accumulation
 			stats: {
 				processed: processedCount,
 				skipped: skippedCount,