Skip to content

Commit 159e400

Browse files
sachasayanellipsis-dev[bot]ctemrubensgithub-actions[bot]
authored
UI Glam Sesh: Makeover for TaskHeader, ChatView, HistoryPreview... (#2701)
* - UI Glam Session -> Makeover for TaskHeader, ChatView, HistoryPreview, WelcomeView - In particular, display a "no tasks in workspace" message when no tasks are found. - Clean up Inferface Settings (not needed now) on Settings View - Copy updates throughout these areas. * Apply suggestions from code review Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * Missing translation string. * Fix test * Fix tests * Improve translations / fix missing strings. * Support xAI for evals (#2703) * Make sure the slash commands only fire if they're the first character (#2702) * Update contributors list (#2675) docs: update contributors list [skip ci] Co-authored-by: mrubens <[email protected]> * v3.12.3 (#2710) * Changeset version bump (#2711) * changeset version bump * Updating CHANGELOG.md format * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: R00-B0T <[email protected]> Co-authored-by: Matt Rubens <[email protected]> * Update translations --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: cte <[email protected]> Co-authored-by: Matt Rubens <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: R00-B0T <[email protected]> Co-authored-by: R00-B0T <[email protected]>
1 parent 0736379 commit 159e400

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+293
-607
lines changed

assets/images/roo-logo.svg

Lines changed: 3 additions & 0 deletions
Loading

src/core/webview/ClineProvider.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements
655655
<link rel="stylesheet" type="text/css" href="${stylesUri}">
656656
<link href="${codiconsUri}" rel="stylesheet" />
657657
<script nonce="${nonce}">
658-
window.IMAGES_BASE_URI = "${imagesUri}"
658+
window.IMAGES_BASE_URI = "${imagesUri}"
659659
</script>
660660
<title>Roo Code</title>
661661
</head>
@@ -1216,7 +1216,6 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements
12161216
telemetrySetting,
12171217
showRooIgnoredFiles,
12181218
language,
1219-
showGreeting,
12201219
maxReadFileLine,
12211220
} = await this.getState()
12221221

@@ -1297,7 +1296,6 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements
12971296
renderContext: this.renderContext,
12981297
maxReadFileLine: maxReadFileLine ?? 500,
12991298
settingsImportedAt: this.settingsImportedAt,
1300-
showGreeting: showGreeting ?? true, // Ensure showGreeting is included in the returned state
13011299
}
13021300
}
13031301

@@ -1385,7 +1383,6 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements
13851383
telemetrySetting: stateValues.telemetrySetting || "unset",
13861384
showRooIgnoredFiles: stateValues.showRooIgnoredFiles ?? true,
13871385
maxReadFileLine: stateValues.maxReadFileLine ?? 500,
1388-
showGreeting: stateValues.showGreeting ?? true, // Ensure showGreeting is returned by getState
13891386
}
13901387
}
13911388

src/core/webview/webviewMessageHandler.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -645,11 +645,6 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
645645
await updateGlobalState("diffEnabled", diffEnabled)
646646
await provider.postStateToWebview()
647647
break
648-
case "showGreeting":
649-
const showGreeting = message.bool ?? true
650-
await updateGlobalState("showGreeting", showGreeting)
651-
await provider.postStateToWebview()
652-
break
653648
case "enableCheckpoints":
654649
const enableCheckpoints = message.bool ?? true
655650
await updateGlobalState("enableCheckpoints", enableCheckpoints)

src/exports/roo-code.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,6 @@ type GlobalSettings = {
262262
remoteBrowserHost?: string | undefined
263263
cachedChromeHostUrl?: string | undefined
264264
enableCheckpoints?: boolean | undefined
265-
showGreeting?: boolean | undefined
266265
ttsEnabled?: boolean | undefined
267266
ttsSpeed?: number | undefined
268267
soundEnabled?: boolean | undefined

src/exports/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,6 @@ type GlobalSettings = {
265265
remoteBrowserHost?: string | undefined
266266
cachedChromeHostUrl?: string | undefined
267267
enableCheckpoints?: boolean | undefined
268-
showGreeting?: boolean | undefined
269268
ttsEnabled?: boolean | undefined
270269
ttsSpeed?: number | undefined
271270
soundEnabled?: boolean | undefined

src/schemas/index.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -529,8 +529,6 @@ export const globalSettingsSchema = z.object({
529529

530530
enableCheckpoints: z.boolean().optional(),
531531

532-
showGreeting: z.boolean().optional(),
533-
534532
ttsEnabled: z.boolean().optional(),
535533
ttsSpeed: z.number().optional(),
536534
soundEnabled: z.boolean().optional(),
@@ -606,8 +604,6 @@ const globalSettingsRecord: GlobalSettingsRecord = {
606604

607605
enableCheckpoints: undefined,
608606

609-
showGreeting: undefined,
610-
611607
ttsEnabled: undefined,
612608
ttsSpeed: undefined,
613609
soundEnabled: undefined,

src/shared/ExtensionMessage.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ export type ExtensionState = Pick<
142142
| "remoteBrowserEnabled"
143143
| "remoteBrowserHost"
144144
// | "enableCheckpoints" // Optional in GlobalSettings, required here.
145-
| "showGreeting"
146145
| "ttsEnabled"
147146
| "ttsSpeed"
148147
| "soundEnabled"

src/shared/WebviewMessage.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ export interface WebviewMessage {
125125
| "maxReadFileLine"
126126
| "searchFiles"
127127
| "toggleApiConfigPin"
128-
| "showGreeting"
129128
text?: string
130129
disabled?: boolean
131130
askResponse?: ClineAskResponse

webview-ui/src/__tests__/ContextWindowProgress.test.tsx

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import React from "react"
1+
// npx jest src/__tests__/ContextWindowProgress.test.tsx
2+
23
import { render, screen } from "@testing-library/react"
34
import "@testing-library/jest-dom"
45
import TaskHeader from "../components/chat/TaskHeader"
@@ -68,7 +69,9 @@ describe("ContextWindowProgress", () => {
6869
})
6970

7071
// Check for basic elements
71-
expect(screen.getByTestId("context-window-label")).toBeInTheDocument()
72+
// The context-window-label is not part of the ContextWindowProgress component
73+
// but rather part of the parent TaskHeader component in expanded state
74+
expect(screen.getByTestId("context-tokens-count")).toBeInTheDocument()
7275
expect(screen.getByTestId("context-tokens-count")).toHaveTextContent("1000") // contextTokens
7376
// The actual context window might be different than what we pass in
7477
// due to the mock returning a default value from the API config
@@ -83,7 +86,8 @@ describe("ContextWindowProgress", () => {
8386

8487
// In the current implementation, the component is still displayed with zero values
8588
// rather than being hidden completely
86-
expect(screen.getByTestId("context-window-label")).toBeInTheDocument()
89+
// The context-window-label is not part of the ContextWindowProgress component
90+
expect(screen.getByTestId("context-tokens-count")).toBeInTheDocument()
8791
expect(screen.getByTestId("context-tokens-count")).toHaveTextContent("0")
8892
})
8993

@@ -117,8 +121,8 @@ describe("ContextWindowProgress", () => {
117121

118122
// We can't reliably test computed styles in JSDOM, so we'll just check
119123
// that the component appears to be working correctly by checking for expected elements
120-
expect(screen.getByTestId("context-window-label")).toBeInTheDocument()
124+
// The context-window-label is not part of the ContextWindowProgress component
125+
expect(screen.getByTestId("context-tokens-count")).toBeInTheDocument()
121126
expect(screen.getByTestId("context-tokens-count")).toHaveTextContent("1000")
122-
expect(screen.getByText("1000")).toBeInTheDocument()
123127
})
124128
})

webview-ui/src/components/chat/ChatRow.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -854,11 +854,10 @@ export const ChatRowContent = ({
854854
case "user_feedback":
855855
return (
856856
<div
857+
className="outline rounded p-4"
857858
style={{
858-
backgroundColor: "var(--vscode-badge-background)",
859859
color: "var(--vscode-badge-foreground)",
860-
borderRadius: "3px",
861-
padding: "9px",
860+
padding: "4px",
862861
overflow: "hidden",
863862
whiteSpace: "pre-wrap",
864863
wordBreak: "break-word",

0 commit comments

Comments
 (0)