Skip to content

Commit 1685d12

Browse files
committed
Fix additional CI failures: Windows compatibility and knip issues
- Improve path resolution for cross-platform compatibility in test file - Expand knip ignore patterns to handle test files and integration directory - Use path.resolve with individual path segments for better Windows support Resolves: - platform-unit-test Windows compatibility issues - knip unused file detection false positives - Cross-platform path handling in tests
1 parent de4cb22 commit 1685d12

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

knip.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,16 @@
22
"$schema": "https://unpkg.com/knip@latest/schema.json",
33
"ignore": [
44
"**/__tests__/**",
5+
"**/*.test.*",
6+
"**/*.spec.*",
57
"apps/vscode-e2e/**",
68
"src/extension/api.ts",
79
"src/activate/**",
810
"src/workers/countTokens.ts",
911
"src/extension.ts",
1012
"scripts/**",
11-
"playwright-mcp-integration/tests/**"
13+
"playwright-mcp-integration/**",
14+
"packages/types/validate-playwright-template.js"
1215
],
1316
"workspaces": {
1417
"src": {

packages/types/src/__tests__/playwright-mcp-validation.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ describe("Playwright MCP Template Validation", () => {
3030
let playwrightMcpItem: any
3131

3232
beforeEach(async () => {
33-
// Read the corrected template file using proper path resolution
34-
const templatePath = path.resolve(__dirname, "../../../../playwright-mcp-integration/playwright-mcp.yaml")
33+
// Read the corrected template file using proper cross-platform path resolution
34+
const templatePath = path.resolve(__dirname, "..", "..", "..", "..", "playwright-mcp-integration", "playwright-mcp.yaml")
3535
templateContent = await fs.readFile(templatePath, "utf-8")
3636
parsedTemplate = yaml.parse(templateContent)
3737

0 commit comments

Comments
 (0)