fix: preserve OpenRouter experimental settings when switching API profiles

- Modified activateProviderProfile to preserve openRouterImageGenerationSettings
- Added tests to verify the fix works correctly
- Ensures experimental image generation settings are not lost during profile switches

Author: roomote

src/core/webview/ClineProvider.ts

@@ -1243,8 +1243,17 @@ export class ClineProvider
 	}
 
 	async activateProviderProfile(args: { name: string } | { id: string }) {
+		// Get current settings to preserve experimental settings
+		const currentSettings = this.contextProxy.getProviderSettings()
+
 		const { name, id, ...providerSettings } = await this.providerSettingsManager.activateProfile(args)
 
+		// Preserve openRouterImageGenerationSettings if it exists in current settings
+		// This ensures experimental settings like the image generation API key are not lost
+		if (currentSettings.openRouterImageGenerationSettings) {
+			providerSettings.openRouterImageGenerationSettings = currentSettings.openRouterImageGenerationSettings
+		}
+
 		// See `upsertProviderProfile` for a description of what this is doing.
 		await Promise.all([
 			this.contextProxy.setValue("listApiConfigMeta", await this.providerSettingsManager.listConfig()),

src/core/webview/__tests__/ClineProvider.spec.ts

@@ -1658,6 +1658,136 @@ describe("ClineProvider", () => {
 			// Verify state was posted to webview
 			expect(mockPostMessage).toHaveBeenCalledWith(expect.objectContaining({ type: "state" }))
 		})
+
+		test("preserves openRouterImageGenerationSettings when switching profiles", async () => {
+			// Set up webview
+			await provider.resolveWebviewView(mockWebviewView)
+			const messageHandler = (mockWebviewView.webview.onDidReceiveMessage as any).mock.calls[0][0]
+
+			// Mock the context proxy to have experimental settings
+			const contextProxy = (provider as any).contextProxy
+			const getProviderSettingsSpy = vi.spyOn(contextProxy, "getProviderSettings")
+			getProviderSettingsSpy.mockReturnValue({
+				apiProvider: "openrouter",
+				openRouterImageGenerationSettings: {
+					openRouterApiKey: "test-experimental-key",
+					selectedModel: "dall-e-3",
+				},
+			})
+
+			// Mock provider settings manager - activateProfile returns the full provider settings
+			const profileSettings = {
+				apiProvider: "anthropic" as const,
+				apiKey: "new-key",
+			}
+
+			;(provider as any).providerSettingsManager = {
+				activateProfile: vi.fn().mockResolvedValue({
+					name: "new-profile",
+					id: "new-profile-id",
+					...profileSettings,
+				}),
+				listConfig: vi.fn().mockResolvedValue([
+					{
+						name: "new-profile",
+						id: "new-profile-id",
+						apiProvider: "anthropic",
+					},
+				]),
+				setModeConfig: vi.fn().mockResolvedValue(undefined),
+			} as any
+
+			// Spy on setProviderSettings to verify the merged settings
+			const setProviderSettingsSpy = vi.spyOn(contextProxy, "setProviderSettings")
+
+			// Spy on activateProviderProfile method
+			const activateProviderProfileSpy = vi.spyOn(provider, "activateProviderProfile")
+
+			// Spy on postStateToWebview
+			const postStateToWebviewSpy = vi.spyOn(provider, "postStateToWebview").mockResolvedValue(undefined)
+
+			// Trigger profile activation via webview message
+			await messageHandler({
+				type: "loadApiConfiguration",
+				text: "new-profile",
+			})
+
+			// Verify that activateProviderProfile was called
+			expect(activateProviderProfileSpy).toHaveBeenCalledWith({ name: "new-profile" })
+
+			// Verify that activateProfile was called
+			expect(provider.providerSettingsManager.activateProfile).toHaveBeenCalledWith({ name: "new-profile" })
+
+			// Verify that setProviderSettings was called with merged settings including experimental settings
+			expect(setProviderSettingsSpy).toHaveBeenCalledWith({
+				apiProvider: "anthropic",
+				apiKey: "new-key",
+				openRouterImageGenerationSettings: {
+					openRouterApiKey: "test-experimental-key",
+					selectedModel: "dall-e-3",
+				},
+			})
+
+			// Verify state was posted to webview
+			expect(postStateToWebviewSpy).toHaveBeenCalled()
+		})
+
+		test("handles missing openRouterImageGenerationSettings when switching profiles", async () => {
+			// Set up webview
+			await provider.resolveWebviewView(mockWebviewView)
+			const messageHandler = (mockWebviewView.webview.onDidReceiveMessage as any).mock.calls[0][0]
+
+			// Mock the context proxy without experimental settings
+			const contextProxy = (provider as any).contextProxy
+			const getProviderSettingsSpy = vi.spyOn(contextProxy, "getProviderSettings")
+			getProviderSettingsSpy.mockReturnValue({
+				apiProvider: "openrouter",
+				// No openRouterImageGenerationSettings
+			})
+
+			// Mock provider settings manager - activateProfile returns the full provider settings
+			const profileSettings = {
+				apiProvider: "anthropic" as const,
+				apiKey: "new-key",
+			}
+
+			;(provider as any).providerSettingsManager = {
+				activateProfile: vi.fn().mockResolvedValue({
+					name: "new-profile",
+					id: "new-profile-id",
+					...profileSettings,
+				}),
+				listConfig: vi.fn().mockResolvedValue([
+					{
+						name: "new-profile",
+						id: "new-profile-id",
+						apiProvider: "anthropic",
+					},
+				]),
+			} as any
+
+			// Spy on setProviderSettings
+			const setProviderSettingsSpy = vi.spyOn(contextProxy, "setProviderSettings")
+
+			// Spy on activateProviderProfile method
+			const activateProviderProfileSpy = vi.spyOn(provider, "activateProviderProfile")
+
+			// Trigger profile activation via webview message
+			await messageHandler({
+				type: "loadApiConfiguration",
+				text: "new-profile",
+			})
+
+			// Verify that activateProviderProfile was called
+			expect(activateProviderProfileSpy).toHaveBeenCalledWith({ name: "new-profile" })
+
+			// Verify that setProviderSettings was called without experimental settings
+			expect(setProviderSettingsSpy).toHaveBeenCalledWith({
+				apiProvider: "anthropic",
+				apiKey: "new-key",
+				// No openRouterImageGenerationSettings
+			})
+		})
 	})
 
 	describe("createTaskWithHistoryItem mode validation", () => {