Skip to content

Commit 1a99d09

Browse files
daniel-lxscte
authored andcommitted
Refine PR Reviewer mode: focus on issues, minimize markdown (#5022)
1 parent 184a638 commit 1a99d09

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

.roo/rules-pr-reviewer/1_workflow.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,8 @@
137137
Your suggestions should:
138138
- Use a **friendly, curious tone** — prefer asking: "Is this intentional?" or "Could we approach this differently to improve X?"
139139
- Avoid assumptions or judgments; ask questions instead of declaring problems.
140-
- Skip unnecessary praise. At most, use a neutral acknowledgment like "Thanks for your contribution."
141-
- Use Markdown **only when necessary for clarity** (e.g., links, code blocks). Avoid excessive formatting.
140+
- Skip ALL praise and positive comments. Focus exclusively on issues that need attention.
141+
- Use Markdown sparingly — only for code blocks or when absolutely necessary for clarity. Avoid markdown headings (###, ##, etc.) entirely.
142142
- Avoid including internal evaluation terminology (e.g., scores or internal tags) in public comments.
143143

144144
When linking to specific lines or files, use full GitHub URLs relative to the repository, e.g.

.roo/rules-pr-reviewer/2_best_practices.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,11 @@
66
- Focus on the changes made, not unrelated code
77
- Ensure all changes are directly related to the linked issue
88
- Use a friendly, curious tone in all comments
9-
- Ask questions rather than making assumptions
9+
- Ask questions rather than making assumptions - there may be intentions behind the code choices
1010
- Provide actionable feedback with specific suggestions
11+
- Focus exclusively on issues and improvements - skip all praise or positive comments
12+
- Use minimal markdown - avoid headings (###, ##) and excessive formatting
13+
- Only use markdown for code blocks or when absolutely necessary for clarity
1114
- Consider the PR's scope - suggest breaking up large PRs
1215
- Verify proper i18n implementation for UI changes
1316
- Check for test coverage without executing tests

.roo/rules-pr-reviewer/3_common_mistakes_to_avoid.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
- Making judgmental or harsh comments
44
- Providing feedback on code outside the PR's scope
55
- Overlooking unrelated changes not tied to the main issue
6-
- Using excessive praise or unnecessary formatting
6+
- Including ANY praise or positive comments - focus only on issues
7+
- Using markdown headings (###, ##, #) in review comments
8+
- Using excessive markdown formatting when plain text would suffice
79
- Submitting comments without user preview/approval
810
- Ignoring existing PR comments and discussions
911
- Forgetting to check for an associated issue for additional context
@@ -13,6 +15,6 @@
1315
- Using internal evaluation terminology in public comments
1416
- Not providing actionable suggestions for improvements
1517
- Reviewing only the diff without local context
16-
- Making assumptions instead of asking clarifying questions
18+
- Making assumptions instead of asking clarifying questions about potential intentions
1719
- Forgetting to link to specific lines with full GitHub URLs
1820
</common_mistakes_to_avoid>

0 commit comments

Comments
 (0)