Skip to content

Commit 1cd633d

Browse files
committed
fix: update ShareButton translation keys and Cloud title in all locales
- Fixed ShareButton.tsx to use "cloud:" translation keys instead of "account:" - Updated all non-English locale files to use "Cloud" as title (technical term) - Added comments explaining ACCOUNT_* telemetry naming for backward compatibility
1 parent 7a94f02 commit 1cd633d

File tree

19 files changed

+25
-20
lines changed

19 files changed

+25
-20
lines changed

webview-ui/src/components/chat/ShareButton.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,15 +257,15 @@ export const ShareButton = ({ item, disabled = false, showLabel = false }: Share
257257
<ul className="text-sm text-vscode-descriptionForeground space-y-2">
258258
<li className="flex items-start">
259259
<span className="mr-2 text-vscode-foreground"></span>
260-
{t("account:cloudBenefitSharing")}
260+
{t("cloud:cloudBenefitSharing")}
261261
</li>
262262
<li className="flex items-start">
263263
<span className="mr-2 text-vscode-foreground"></span>
264-
{t("account:cloudBenefitHistory")}
264+
{t("cloud:cloudBenefitHistory")}
265265
</li>
266266
<li className="flex items-start">
267267
<span className="mr-2 text-vscode-foreground"></span>
268-
{t("account:cloudBenefitMetrics")}
268+
{t("cloud:cloudBenefitMetrics")}
269269
</li>
270270
</ul>
271271
</div>

webview-ui/src/components/cloud/CloudView.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,25 +31,30 @@ export const CloudView = ({ userInfo, isAuthenticated, cloudApiUrl, onDone }: Cl
3131
wasAuthenticatedRef.current = true
3232
} else if (wasAuthenticatedRef.current && !isAuthenticated) {
3333
// User just logged out successfully
34+
// NOTE: Telemetry events use ACCOUNT_* naming for continuity with existing analytics
35+
// and to maintain historical data consistency, even though the UI now uses "Cloud" terminology
3436
telemetryClient.capture(TelemetryEventName.ACCOUNT_LOGOUT_SUCCESS)
3537
wasAuthenticatedRef.current = false
3638
}
3739
}, [isAuthenticated])
3840

3941
const handleConnectClick = () => {
4042
// Send telemetry for cloud connect action
43+
// NOTE: Using ACCOUNT_* telemetry events for backward compatibility with analytics
4144
telemetryClient.capture(TelemetryEventName.ACCOUNT_CONNECT_CLICKED)
4245
vscode.postMessage({ type: "rooCloudSignIn" })
4346
}
4447

4548
const handleLogoutClick = () => {
4649
// Send telemetry for cloud logout action
50+
// NOTE: Using ACCOUNT_* telemetry events for backward compatibility with analytics
4751
telemetryClient.capture(TelemetryEventName.ACCOUNT_LOGOUT_CLICKED)
4852
vscode.postMessage({ type: "rooCloudSignOut" })
4953
}
5054

5155
const handleVisitCloudWebsite = () => {
5256
// Send telemetry for cloud website visit
57+
// NOTE: Using ACCOUNT_* telemetry events for backward compatibility with analytics
5358
telemetryClient.capture(TelemetryEventName.ACCOUNT_CONNECT_CLICKED)
5459
const cloudUrl = cloudApiUrl || "https://app.roocode.com"
5560
vscode.postMessage({ type: "openExternal", url: cloudUrl })

webview-ui/src/i18n/locales/ca/cloud.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/de/cloud.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/es/cloud.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/fr/cloud.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/hi/cloud.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/id/cloud.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/it/cloud.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/ja/cloud.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)