Update path and path testing logic

Author: nissa-seru

src/utils/__tests__/path.test.ts

@@ -28,6 +28,40 @@ describe("Path Utilities", () => {
 		})
 	})
 
+	describe("platform-specific behavior", () => {
+		const platforms = ["win32", "darwin", "linux"]
+		platforms.forEach(platform => {
+			describe(`on ${platform}`, () => {
+				beforeEach(() => {
+					Object.defineProperty(process, "platform", { value: platform })
+				})
+
+				it("should handle root paths correctly", () => {
+					const root = platform === "win32" ? "C:\\" : "/"
+					expect(arePathsEqual(root, root + "/")).toBe(true)
+					expect(arePathsEqual(root, root + "//")).toBe(true)
+				})
+
+				it("should normalize mixed separators", () => {
+					const mixedPath = platform === "win32"
+						? "C:\\Users/test\\path/file.txt"
+						: "/Users/test\\path/file.txt"
+					const normalPath = platform === "win32"
+						? "C:\\Users\\test\\path\\file.txt"
+						: "/Users/test/path/file.txt"
+					expect(arePathsEqual(mixedPath, normalPath)).toBe(true)
+				})
+
+				it("should handle parent directory traversal", () => {
+					const base = platform === "win32" ? "C:\\Users\\test" : "/Users/test"
+					const path1 = path.join(base, "dir", "..", "file.txt")
+					const path2 = path.join(base, "file.txt")
+					expect(arePathsEqual(path1, path2)).toBe(true)
+				})
+			})
+		})
+	})
+
 	describe("arePathsEqual", () => {
 		describe("on Windows", () => {
 			beforeEach(() => {
@@ -75,6 +109,73 @@ describe("Path Utilities", () => {
 			})
 		})
 
+		describe("Windows-specific paths", () => {
+			beforeEach(() => {
+				Object.defineProperty(process, "platform", { value: "win32" })
+			})
+
+			it("should handle drive letter case variations", () => {
+				expect(arePathsEqual("C:\\Users\\test", "c:\\users\\test")).toBe(true)
+				expect(arePathsEqual("D:\\Files\\test", "d:\\files\\test")).toBe(true)
+			})
+
+			it("should handle UNC paths", () => {
+				expect(arePathsEqual(
+					"\\\\server\\share\\folder",
+					"\\\\SERVER\\share\\folder"
+				)).toBe(true)
+				expect(arePathsEqual(
+					"\\\\server\\share\\folder\\",
+					"\\\\server\\share\\folder"
+				)).toBe(true)
+			})
+
+			it("should handle extended-length paths", () => {
+				const path1 = "\\\\?\\C:\\Very\\Long\\Path"
+				const path2 = "\\\\?\\C:\\Very\\Long\\Path\\"
+				expect(arePathsEqual(path1, path2)).toBe(true)
+			})
+
+			it("should handle network drive paths", () => {
+				expect(arePathsEqual(
+					"Z:\\Shared\\Files",
+					"z:\\shared\\files"
+				)).toBe(true)
+			})
+		})
+
+		describe("path segment variations", () => {
+			const platforms = ["win32", "darwin", "linux"]
+			platforms.forEach(platform => {
+				describe(`on ${platform}`, () => {
+					beforeEach(() => {
+						Object.defineProperty(process, "platform", { value: platform })
+					})
+
+					it("should handle consecutive separators", () => {
+						const base = platform === "win32" ? "C:" : ""
+						const path1 = `${base}//home///user////file.txt`
+						const path2 = `${base}/home/user/file.txt`
+						expect(arePathsEqual(path1, path2)).toBe(true)
+					})
+
+					it("should handle current directory references", () => {
+						const base = platform === "win32" ? "C:" : ""
+						const path1 = `${base}/./home/./user/./file.txt`
+						const path2 = `${base}/home/user/file.txt`
+						expect(arePathsEqual(path1, path2)).toBe(true)
+					})
+
+					it("should handle complex parent directory traversal", () => {
+						const base = platform === "win32" ? "C:" : ""
+						const path1 = `${base}/a/b/c/../../d/../e/f/../g`
+						const path2 = `${base}/a/e/g`
+						expect(arePathsEqual(path1, path2)).toBe(true)
+					})
+				})
+			})
+		})
+
 		describe("edge cases", () => {
 			it("should handle undefined paths", () => {
 				expect(arePathsEqual(undefined, undefined)).toBe(true)

src/utils/path.ts

@@ -68,14 +68,45 @@ export function arePathsEqual(path1?: string, path2?: string): boolean {
 }
 
 function normalizePath(p: string): string {
-	// normalize resolve ./.. segments, removes duplicate slashes, and standardizes path separators
-	let normalized = path.normalize(p)
-	// however it doesn't remove trailing slashes
-	// remove trailing slash, except for root paths
-	if (normalized.length > 1 && (normalized.endsWith("/") || normalized.endsWith("\\"))) {
-		normalized = normalized.slice(0, -1)
+	if (process.platform !== "win32") {
+		// For POSIX platforms, handle path normalization manually
+		// Convert all separators to forward slashes first
+		let normalized = p.replace(/\\/g, "/")
+		// Remove consecutive slashes except for UNC paths
+		normalized = normalized.replace(/\/+/g, "/")
+		// Remove trailing slash except for root
+		if (normalized.length > 1 && normalized.endsWith("/")) {
+			normalized = normalized.slice(0, -1)
+		}
+		// Resolve . and .. segments
+		const segments = normalized.split("/")
+		const result = []
+		for (const segment of segments) {
+			if (segment === "." || segment === "") {
+				continue
+			}
+			if (segment === "..") {
+				result.pop()
+			} else {
+				result.push(segment)
+			}
+		}
+		// Reconstruct the path
+		normalized = result.join("/")
+		// Handle root path
+		if (p.startsWith("/")) {
+			normalized = "/" + normalized
+		}
+		return normalized
+	} else {
+		// For Windows, use built-in normalize
+		let normalized = path.normalize(p)
+		// Remove trailing slash except for root paths
+		if (normalized.length > 1 && (normalized.endsWith("/") || normalized.endsWith("\\"))) {
+			normalized = normalized.slice(0, -1)
+		}
+		return normalized
 	}
-	return normalized
 }
 
 export function getReadablePath(cwd: string, relPath?: string): string {