Cleanup

Author: mrubens

packages/cloud/src/bridge/BridgeOrchestrator.ts

@@ -61,13 +61,19 @@ export class BridgeOrchestrator {
 	public static async connectOrDisconnect(
 		userInfo: CloudUserInfo | null,
 		remoteControlEnabled: boolean | undefined,
-		options: BridgeOrchestratorOptions,
+		options?: BridgeOrchestratorOptions,
 	): Promise<void> {
 		const isEnabled = BridgeOrchestrator.isEnabled(userInfo, remoteControlEnabled)
 		const instance = BridgeOrchestrator.instance
 
 		if (isEnabled) {
 			if (!instance) {
+				if (!options) {
+					console.error(
+						`[BridgeOrchestrator#connectOrDisconnect] Cannot connect: options are required for connection`,
+					)
+					return
+				}
 				try {
 					console.log(`[BridgeOrchestrator#connectOrDisconnect] Connecting...`)
 					BridgeOrchestrator.instance = new BridgeOrchestrator(options)

src/extension.ts

@@ -135,14 +135,9 @@ export async function activate(context: vscode.ExtensionContext) {
 		if (data.state === "logged-out") {
 			try {
 				// Disconnect the bridge when user logs out
-				// Pass null userInfo and false for remoteControlEnabled to trigger disconnection
-				await BridgeOrchestrator.connectOrDisconnect(null, false, {
-					userId: "",
-					socketBridgeUrl: "",
-					token: "",
-					provider,
-					sessionId: vscode.env.sessionId,
-				})
+				// When userInfo is null and remoteControlEnabled is false, BridgeOrchestrator
+				// will disconnect. The options parameter is not needed for disconnection.
+				await BridgeOrchestrator.connectOrDisconnect(null, false)
 
 				cloudLogger("[CloudService] BridgeOrchestrator disconnected on logout")
 			} catch (error) {