Cloud: only fetch settings when the session is available

jr · jr · commit 2015290a3f29 · 2025-06-23T11:41:03.000-07:00
diff --git a/packages/cloud/src/SettingsService.ts b/packages/cloud/src/SettingsService.ts
@@ -42,10 +42,6 @@ export class SettingsService {
 			this.removeSettings()
 		}
 
-		this.authService.on("attempting-session", () => {
-			this.timer.start()
-		})
-
 		this.authService.on("active-session", () => {
 			this.timer.start()
 		})
@@ -55,7 +51,7 @@ export class SettingsService {
 			this.removeSettings()
 		})
 
-		if (this.authService.hasOrIsAcquiringActiveSession()) {
+		if (this.authService.hasActiveSession()) {
 			this.timer.start()
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -42,10 +42,6 @@ export class SettingsService {`
`42`	`42`	`this.removeSettings()`
`43`	`43`	`}`
`44`	`44`
`45`		`- this.authService.on("attempting-session", () => {`
`46`		`- this.timer.start()`
`47`		`- })`
`48`		`-`
`49`	`45`	`this.authService.on("active-session", () => {`
`50`	`46`	`this.timer.start()`
`51`	`47`	`})`
`@@ -55,7 +51,7 @@ export class SettingsService {`
`55`	`51`	`this.removeSettings()`
`56`	`52`	`})`
`57`	`53`
`58`		`- if (this.authService.hasOrIsAcquiringActiveSession()) {`
	`54`	`+ if (this.authService.hasActiveSession()) {`
`59`	`55`	`this.timer.start()`
`60`	`56`	`}`
`61`	`57`	`}`