UI changes + refactor

Author: liwilliam2021

src/services/rules/__tests__/rulesGenerator.test.ts

@@ -0,0 +1,100 @@
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"
+import * as fs from "fs/promises"
+import * as path from "path"
+import { createRulesGenerationTaskMessage } from "../rulesGenerator"
+
+// Mock fs module
+vi.mock("fs/promises", () => ({
+	mkdir: vi.fn(),
+}))
+
+describe("rulesGenerator", () => {
+	const mockWorkspacePath = "/test/workspace"
+
+	beforeEach(() => {
+		vi.clearAllMocks()
+	})
+
+	afterEach(() => {
+		vi.restoreAllMocks()
+	})
+
+	describe("createRulesGenerationTaskMessage", () => {
+		it("should create directories when alwaysAllowWriteProtected is true", async () => {
+			await createRulesGenerationTaskMessage(mockWorkspacePath, ["general"], false, true)
+
+			// Verify mkdir was called for each directory
+			expect(fs.mkdir).toHaveBeenCalledWith(path.join(mockWorkspacePath, ".roo", "rules"), { recursive: true })
+			expect(fs.mkdir).toHaveBeenCalledWith(path.join(mockWorkspacePath, ".roo", "rules-code"), {
+				recursive: true,
+			})
+			expect(fs.mkdir).toHaveBeenCalledWith(path.join(mockWorkspacePath, ".roo", "rules-architect"), {
+				recursive: true,
+			})
+			expect(fs.mkdir).toHaveBeenCalledWith(path.join(mockWorkspacePath, ".roo", "rules-debug"), {
+				recursive: true,
+			})
+			expect(fs.mkdir).toHaveBeenCalledWith(path.join(mockWorkspacePath, ".roo", "rules-docs-extractor"), {
+				recursive: true,
+			})
+		})
+
+		it("should NOT create directories when alwaysAllowWriteProtected is false", async () => {
+			await createRulesGenerationTaskMessage(mockWorkspacePath, ["general"], false, false)
+
+			// Verify mkdir was NOT called
+			expect(fs.mkdir).not.toHaveBeenCalled()
+		})
+
+		it("should include auto-approval note in message when alwaysAllowWriteProtected is true", async () => {
+			const message = await createRulesGenerationTaskMessage(mockWorkspacePath, ["general"], false, true)
+
+			expect(message).toContain("The directory has already been created for you")
+			expect(message).toContain("Auto-approval for protected file writes is enabled")
+		})
+
+		it("should include manual approval note in message when alwaysAllowWriteProtected is false", async () => {
+			const message = await createRulesGenerationTaskMessage(mockWorkspacePath, ["general"], false, false)
+
+			expect(message).toContain("Create the necessary directories if they don't exist")
+			expect(message).toContain("You will need to approve the creation of protected directories and files")
+		})
+
+		it("should handle multiple rule types", async () => {
+			const message = await createRulesGenerationTaskMessage(
+				mockWorkspacePath,
+				["general", "code", "architect"],
+				false,
+				true,
+			)
+
+			expect(message).toContain(".roo/rules/coding-standards.md")
+			expect(message).toContain(".roo/rules-code/implementation-rules.md")
+			expect(message).toContain(".roo/rules-architect/architecture-rules.md")
+		})
+
+		it("should include gitignore instructions when addToGitignore is true", async () => {
+			const message = await createRulesGenerationTaskMessage(mockWorkspacePath, ["general"], true, false)
+
+			expect(message).toContain("Add the generated files to .gitignore")
+		})
+
+		it("should include analysis steps for each rule type", async () => {
+			const message = await createRulesGenerationTaskMessage(mockWorkspacePath, ["code"], false, false)
+
+			// Check that code-specific analysis steps are included
+			expect(message).toContain("Analyze package.json or equivalent files")
+			expect(message).toContain("Check for linting and formatting tools")
+			expect(message).toContain("Examine test files to understand testing patterns")
+		})
+
+		it("should include different analysis steps for different rule types", async () => {
+			const message = await createRulesGenerationTaskMessage(mockWorkspacePath, ["architect"], false, false)
+
+			// Check that architect-specific analysis steps are included
+			expect(message).toContain("Analyze the overall directory structure")
+			expect(message).toContain("Identify architectural patterns")
+			expect(message).toContain("separation of concerns")
+		})
+	})
+})