fix(webview): include settingsArray in AutoApproveDropdown dependencies to satisfy eslint react-hooks/exhaustive-deps

hannesrudolph · hannesrudolph · commit 24a39fd6a68a · 2025-10-22T16:47:15.000-06:00
diff --git a/webview-ui/src/components/chat/AutoApproveDropdown.tsx b/webview-ui/src/components/chat/AutoApproveDropdown.tsx
@@ -155,7 +155,7 @@ export const AutoApproveDropdown = ({ disabled = false, triggerClassName = "" }:
 	// Filter out Browser toggle when browser tool is disabled
 	const visibleSettingsArray = React.useMemo(
 		() => settingsArray.filter((s) => browserToolEnabled || s.key !== "alwaysAllowBrowser"),
-		[browserToolEnabled],
+		[settingsArray, browserToolEnabled],
 	)
 
 	const visibleKeys = React.useMemo(() => visibleSettingsArray.map((s) => s.key), [visibleSettingsArray])

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ export const AutoApproveDropdown = ({ disabled = false, triggerClassName = "" }:`
`155`	`155`	`// Filter out Browser toggle when browser tool is disabled`
`156`	`156`	`const visibleSettingsArray = React.useMemo(`
`157`	`157`	`() => settingsArray.filter((s) => browserToolEnabled \|\| s.key !== "alwaysAllowBrowser"),`
`158`		`- [browserToolEnabled],`
	`158`	`+ [settingsArray, browserToolEnabled],`
`159`	`159`	`)`
`160`	`160`
`161`	`161`	`const visibleKeys = React.useMemo(() => visibleSettingsArray.map((s) => s.key), [visibleSettingsArray])`