Skip to content

Commit 25e55aa

Browse files
committed
Remove some unnecessary instance methods from Task
1 parent 29a345c commit 25e55aa

File tree

9 files changed

+14
-21
lines changed

9 files changed

+14
-21
lines changed

src/core/task/Task.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ export class Task extends EventEmitter<ClineEvents> {
165165
consecutiveMistakeCount: number = 0
166166
consecutiveMistakeLimit: number
167167
consecutiveMistakeCountForApplyDiff: Map<string, number> = new Map()
168-
private toolUsage: ToolUsage = {}
168+
toolUsage: ToolUsage = {}
169169

170170
// Checkpoints
171171
enableCheckpoints: boolean
@@ -1659,17 +1659,9 @@ export class Task extends EventEmitter<ClineEvents> {
16591659
}
16601660
}
16611661

1662-
public getToolUsage() {
1663-
return this.toolUsage
1664-
}
1665-
16661662
// Getters
16671663

16681664
public get cwd() {
16691665
return this.workspacePath
16701666
}
1671-
1672-
public getFileContextTracker(): FileContextTracker {
1673-
return this.fileContextTracker
1674-
}
16751667
}

src/core/tools/__tests__/readFileTool.test.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ describe("read_file tool with maxReadFileLine setting", () => {
129129
mockCline.say = jest.fn().mockResolvedValue(undefined)
130130
mockCline.ask = jest.fn().mockResolvedValue(true)
131131
mockCline.presentAssistantMessage = jest.fn()
132-
mockCline.getFileContextTracker = jest.fn().mockReturnValue({
132+
mockCline.fileContextTracker = jest.fn().mockReturnValue({
133133
trackFileContext: jest.fn().mockResolvedValue(undefined),
134134
})
135135
mockCline.recordToolUsage = jest.fn().mockReturnValue(undefined)
@@ -459,10 +459,11 @@ describe("read_file tool XML output structure", () => {
459459
mockCline.ask = jest.fn().mockResolvedValue(true)
460460
mockCline.presentAssistantMessage = jest.fn()
461461
mockCline.sayAndCreateMissingParamError = jest.fn().mockResolvedValue("Missing required parameter")
462-
// Add mock for getFileContextTracker method
463-
mockCline.getFileContextTracker = jest.fn().mockReturnValue({
462+
463+
mockCline.fileContextTracker = jest.fn().mockReturnValue({
464464
trackFileContext: jest.fn().mockResolvedValue(undefined),
465465
})
466+
466467
mockCline.recordToolUsage = jest.fn().mockReturnValue(undefined)
467468
mockCline.recordToolError = jest.fn().mockReturnValue(undefined)
468469

src/core/tools/applyDiffTool.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ export async function applyDiffTool(
164164

165165
// Track file edit operation
166166
if (relPath) {
167-
await cline.getFileContextTracker().trackFileContext(relPath, "roo_edited" as RecordSource)
167+
await cline.fileContextTracker.trackFileContext(relPath, "roo_edited" as RecordSource)
168168
}
169169

170170
// Used to determine if we should wait for busy terminal to update before sending api request

src/core/tools/attemptCompletionTool.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export async function attemptCompletionTool(
4646
await cline.say("completion_result", removeClosingTag("result", result), undefined, false)
4747

4848
telemetryService.captureTaskCompleted(cline.taskId)
49-
cline.emit("taskCompleted", cline.taskId, cline.getTokenUsage(), cline.getToolUsage())
49+
cline.emit("taskCompleted", cline.taskId, cline.getTokenUsage(), cline.toolUsage)
5050

5151
await cline.ask("command", removeClosingTag("command", command), block.partial).catch(() => {})
5252
}
@@ -72,7 +72,7 @@ export async function attemptCompletionTool(
7272
// Haven't sent a command message yet so first send completion_result then command.
7373
await cline.say("completion_result", result, undefined, false)
7474
telemetryService.captureTaskCompleted(cline.taskId)
75-
cline.emit("taskCompleted", cline.taskId, cline.getTokenUsage(), cline.getToolUsage())
75+
cline.emit("taskCompleted", cline.taskId, cline.getTokenUsage(), cline.toolUsage)
7676
}
7777

7878
// Complete command message.
@@ -97,7 +97,7 @@ export async function attemptCompletionTool(
9797
} else {
9898
await cline.say("completion_result", result, undefined, false)
9999
telemetryService.captureTaskCompleted(cline.taskId)
100-
cline.emit("taskCompleted", cline.taskId, cline.getTokenUsage(), cline.getToolUsage())
100+
cline.emit("taskCompleted", cline.taskId, cline.getTokenUsage(), cline.toolUsage)
101101
}
102102

103103
if (cline.parentTask) {

src/core/tools/insertContentTool.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export async function insertContentTool(
132132

133133
// Track file edit operation
134134
if (relPath) {
135-
await cline.getFileContextTracker().trackFileContext(relPath, "roo_edited" as RecordSource)
135+
await cline.fileContextTracker.trackFileContext(relPath, "roo_edited" as RecordSource)
136136
}
137137

138138
cline.didEditFile = true

src/core/tools/listCodeDefinitionNamesTool.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export async function listCodeDefinitionNamesTool(
6464
}
6565

6666
if (relPath) {
67-
await cline.getFileContextTracker().trackFileContext(relPath, "read_tool" as RecordSource)
67+
await cline.fileContextTracker.trackFileContext(relPath, "read_tool" as RecordSource)
6868
}
6969

7070
pushToolResult(result)

src/core/tools/readFileTool.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ export async function readFileTool(
245245

246246
// Track file read operation
247247
if (relPath) {
248-
await cline.getFileContextTracker().trackFileContext(relPath, "read_tool" as RecordSource)
248+
await cline.fileContextTracker.trackFileContext(relPath, "read_tool" as RecordSource)
249249
}
250250

251251
// Format the result into the required XML structure

src/core/tools/searchAndReplaceTool.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ export async function searchAndReplaceTool(
215215

216216
// Track file edit operation
217217
if (relPath) {
218-
await cline.getFileContextTracker().trackFileContext(relPath, "roo_edited" as RecordSource)
218+
await cline.fileContextTracker.trackFileContext(relPath, "roo_edited" as RecordSource)
219219
}
220220

221221
cline.didEditFile = true

src/core/tools/writeToFileTool.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ export async function writeToFileTool(
211211

212212
// Track file edit operation
213213
if (relPath) {
214-
await cline.getFileContextTracker().trackFileContext(relPath, "roo_edited" as RecordSource)
214+
await cline.fileContextTracker.trackFileContext(relPath, "roo_edited" as RecordSource)
215215
}
216216

217217
cline.didEditFile = true // used to determine if we should wait for busy terminal to update before sending api request

0 commit comments

Comments
 (0)