Skip to content

Commit 2625ede

Browse files
committed
chore: clean up debug logging and remove working document
- Remove all console.log statements added for debugging - Remove CHAT_MESSAGE_FIX_SUMMARY.md working document - Keep core fix logic for timestamp-based fallback - Keep UI update after deletion - Keep comprehensive test coverage All tests passing after cleanup
1 parent e1b9be1 commit 2625ede

File tree

3 files changed

+0
-222
lines changed

3 files changed

+0
-222
lines changed

CHAT_MESSAGE_FIX_SUMMARY.md

Lines changed: 0 additions & 126 deletions
This file was deleted.

src/core/webview/ClineProvider.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -928,9 +928,6 @@ export class ClineProvider
928928

929929
if (fallbackIndex !== -1) {
930930
effectiveApiIndex = fallbackIndex
931-
this.log(
932-
`[createTaskWithHistoryItem] Using timestamp-based fallback for API history truncation. Index: ${effectiveApiIndex}`,
933-
)
934931
}
935932
}
936933

src/core/webview/webviewMessageHandler.ts

Lines changed: 0 additions & 93 deletions
Original file line numberDiff line numberDiff line change
@@ -93,25 +93,12 @@ export const webviewMessageHandler = async (
9393
apiConversationHistoryIndex: number,
9494
messageTs?: number,
9595
) => {
96-
console.log(
97-
`[removeMessagesThisAndSubsequent] Starting with messageIndex: ${messageIndex}, apiIndex: ${apiConversationHistoryIndex}, messageTs: ${messageTs}`,
98-
)
99-
console.log(
100-
`[removeMessagesThisAndSubsequent] Current clineMessages length: ${currentCline.clineMessages.length}`,
101-
)
102-
console.log(
103-
`[removeMessagesThisAndSubsequent] Current apiConversationHistory length: ${currentCline.apiConversationHistory.length}`,
104-
)
105-
10696
// Delete this message and all that follow
10797
await currentCline.overwriteClineMessages(currentCline.clineMessages.slice(0, messageIndex))
108-
console.log(`[removeMessagesThisAndSubsequent] Truncated clineMessages to ${messageIndex} messages`)
10998

11099
// If apiConversationHistoryIndex is -1, use timestamp-based fallback
111100
let effectiveApiIndex = apiConversationHistoryIndex
112101
if (apiConversationHistoryIndex === -1 && messageTs && currentCline.apiConversationHistory.length > 0) {
113-
console.log(`[removeMessagesThisAndSubsequent] API index is -1, attempting timestamp-based fallback`)
114-
115102
// Find the first API message with timestamp >= messageTs
116103
// This ensures we remove any assistant responses that came after the deleted user message
117104
const fallbackIndex = currentCline.apiConversationHistory.findIndex((msg: ApiMessage) => {
@@ -120,68 +107,40 @@ export const webviewMessageHandler = async (
120107

121108
if (fallbackIndex !== -1) {
122109
effectiveApiIndex = fallbackIndex
123-
console.log(
124-
`[removeMessagesThisAndSubsequent] Using timestamp-based fallback for API history truncation. Index: ${effectiveApiIndex}`,
125-
)
126-
} else {
127-
console.log(`[removeMessagesThisAndSubsequent] No API messages found with timestamp >= ${messageTs}`)
128110
}
129111
}
130112

131113
if (effectiveApiIndex !== -1) {
132-
console.log(`[removeMessagesThisAndSubsequent] Truncating API history at index ${effectiveApiIndex}`)
133114
await currentCline.overwriteApiConversationHistory(
134115
currentCline.apiConversationHistory.slice(0, effectiveApiIndex),
135116
)
136-
console.log(`[removeMessagesThisAndSubsequent] API history truncated to ${effectiveApiIndex} messages`)
137-
} else {
138-
console.log(
139-
`[removeMessagesThisAndSubsequent] No API history truncation needed (effectiveApiIndex: ${effectiveApiIndex})`,
140-
)
141117
}
142118
}
143119

144120
/**
145121
* Handles message deletion operations with user confirmation
146122
*/
147123
const handleDeleteOperation = async (messageTs: number): Promise<void> => {
148-
console.log(`[handleDeleteOperation] Starting delete operation for messageTs: ${messageTs}`)
149-
150124
// Check if there's a checkpoint before this message
151125
const currentCline = provider.getCurrentTask()
152126
let hasCheckpoint = false
153127

154128
if (!currentCline) {
155-
console.error("[handleDeleteOperation] No current task available")
156129
await vscode.window.showErrorMessage("No active task to delete messages from")
157130
return
158131
}
159132

160-
console.log(`[handleDeleteOperation] Current task found, checking for message with ts: ${messageTs}`)
161-
console.log(`[handleDeleteOperation] Total messages in clineMessages: ${currentCline.clineMessages.length}`)
162-
163133
const { messageIndex } = findMessageIndices(messageTs, currentCline)
164-
console.log(`[handleDeleteOperation] Found message at index: ${messageIndex}`)
165134

166135
if (messageIndex !== -1) {
167136
// Find the last checkpoint before this message
168137
const checkpoints = currentCline.clineMessages.filter(
169138
(msg) => msg.say === "checkpoint_saved" && msg.ts > messageTs,
170139
)
171140
hasCheckpoint = checkpoints.length > 0
172-
console.log(`[handleDeleteOperation] Has checkpoint after message: ${hasCheckpoint}`)
173-
} else {
174-
console.error(`[handleDeleteOperation] Message not found! Looking for ts: ${messageTs}`)
175-
// Log first few message timestamps for debugging
176-
const firstFewTimestamps = currentCline.clineMessages
177-
.slice(0, 5)
178-
.map((msg: ClineMessage) => msg.ts)
179-
.filter(Boolean)
180-
console.error(`[handleDeleteOperation] First few message timestamps: ${firstFewTimestamps.join(", ")}`)
181141
}
182142

183143
// Send message to webview to show delete confirmation dialog
184-
console.log(`[handleDeleteOperation] Sending showDeleteMessageDialog to webview`)
185144
await provider.postMessageToWebview({
186145
type: "showDeleteMessageDialog",
187146
messageTs,
@@ -199,27 +158,10 @@ export const webviewMessageHandler = async (
199158
return
200159
}
201160

202-
console.log(`[handleDeleteMessageConfirm] Attempting to delete message with timestamp: ${messageTs}`)
203-
console.log(`[handleDeleteMessageConfirm] Total clineMessages: ${currentCline.clineMessages.length}`)
204-
console.log(
205-
`[handleDeleteMessageConfirm] Total apiConversationHistory: ${currentCline.apiConversationHistory.length}`,
206-
)
207-
208161
const { messageIndex, apiConversationHistoryIndex } = findMessageIndices(messageTs, currentCline)
209162

210-
console.log(
211-
`[handleDeleteMessageConfirm] Found messageIndex: ${messageIndex}, apiConversationHistoryIndex: ${apiConversationHistoryIndex}`,
212-
)
213-
214163
if (messageIndex === -1) {
215-
// Log available message timestamps for debugging
216-
const availableTimestamps = currentCline.clineMessages.map((msg: ClineMessage) => msg.ts).filter(Boolean)
217-
console.error(
218-
`[handleDeleteMessageConfirm] Available message timestamps: ${availableTimestamps.join(", ")}`,
219-
)
220-
221164
const errorMessage = `Message with timestamp ${messageTs} not found`
222-
console.error("[handleDeleteMessageConfirm]", errorMessage)
223165
await vscode.window.showErrorMessage(errorMessage)
224166
return
225167
}
@@ -412,9 +354,6 @@ export const webviewMessageHandler = async (
412354

413355
if (fallbackIndex !== -1) {
414356
effectiveApiIndex = fallbackIndex
415-
console.log(
416-
`[handleEditMessageConfirm] Using timestamp-based fallback for API history truncation. Index: ${effectiveApiIndex}`,
417-
)
418357
}
419358
}
420359

@@ -466,20 +405,10 @@ export const webviewMessageHandler = async (
466405
editedContent?: string,
467406
images?: string[],
468407
): Promise<void> => {
469-
console.log(`[handleMessageModificationsOperation] Starting ${operation} operation for messageTs: ${messageTs}`)
470-
471408
if (operation === "delete") {
472-
console.log(`[handleMessageModificationsOperation] Calling handleDeleteOperation`)
473409
await handleDeleteOperation(messageTs)
474-
console.log(`[handleMessageModificationsOperation] handleDeleteOperation completed`)
475410
} else if (operation === "edit" && editedContent) {
476-
console.log(`[handleMessageModificationsOperation] Calling handleEditOperation`)
477411
await handleEditOperation(messageTs, editedContent, images)
478-
console.log(`[handleMessageModificationsOperation] handleEditOperation completed`)
479-
} else {
480-
console.error(
481-
`[handleMessageModificationsOperation] Invalid operation or missing content: operation=${operation}, hasContent=${!!editedContent}`,
482-
)
483412
}
484413
}
485414

@@ -1560,27 +1489,17 @@ export const webviewMessageHandler = async (
15601489
}
15611490
break
15621491
case "deleteMessage": {
1563-
console.log(
1564-
`[deleteMessage case] Received delete message request with value: ${message.value}, type: ${typeof message.value}`,
1565-
)
1566-
15671492
if (!provider.getCurrentTask()) {
1568-
console.error("[deleteMessage case] No current task available")
15691493
await vscode.window.showErrorMessage("No active task to delete messages from")
15701494
break
15711495
}
15721496

15731497
if (typeof message.value !== "number" || !message.value) {
1574-
console.error(
1575-
`[deleteMessage case] Invalid message value: ${message.value} (type: ${typeof message.value})`,
1576-
)
15771498
await vscode.window.showErrorMessage("Invalid message timestamp for deletion")
15781499
break
15791500
}
15801501

1581-
console.log(`[deleteMessage case] Proceeding with delete operation for timestamp: ${message.value}`)
15821502
await handleMessageModificationsOperation(message.value, "delete")
1583-
console.log(`[deleteMessage case] Delete operation completed`)
15841503
break
15851504
}
15861505
case "submitEditedMessage": {
@@ -1968,29 +1887,17 @@ export const webviewMessageHandler = async (
19681887
}
19691888
break
19701889
case "deleteMessageConfirm":
1971-
console.log(
1972-
`[deleteMessageConfirm case] Received confirmation with messageTs: ${message.messageTs}, restoreCheckpoint: ${message.restoreCheckpoint}`,
1973-
)
1974-
19751890
if (!message.messageTs) {
1976-
console.error("[deleteMessageConfirm case] No messageTs provided in confirmation")
19771891
await vscode.window.showErrorMessage("Cannot delete message: missing timestamp")
19781892
break
19791893
}
19801894

19811895
if (typeof message.messageTs !== "number") {
1982-
console.error(
1983-
`[deleteMessageConfirm case] Invalid messageTs type: ${typeof message.messageTs}, value: ${message.messageTs}`,
1984-
)
19851896
await vscode.window.showErrorMessage("Cannot delete message: invalid timestamp")
19861897
break
19871898
}
19881899

1989-
console.log(
1990-
`[deleteMessageConfirm case] Calling handleDeleteMessageConfirm with messageTs: ${message.messageTs}`,
1991-
)
19921900
await handleDeleteMessageConfirm(message.messageTs, message.restoreCheckpoint)
1993-
console.log(`[deleteMessageConfirm case] handleDeleteMessageConfirm completed`)
19941901
break
19951902
case "editMessageConfirm":
19961903
if (message.messageTs && message.text) {

0 commit comments

Comments
 (0)