Commit 263d260
committed
feat: make attempt_completion tool conditional based on task context
- Add isOrchestrated flag to Task class to track subtask context
- Always include attempt_completion for orchestrated subtasks
- Make attempt_completion optional for standard tasks via allowAttemptCompletion setting
- Default behavior excludes attempt_completion for standard tasks
- Add comprehensive tests for conditional inclusion logic
- Update UI components to expose the new setting
- Update snapshots to reflect new default behavior
Fixes #75291 parent 1d46bd1 commit 263d260
File tree
26 files changed
+339
-249
lines changed- packages/types/src
- src
- core
- prompts
- __tests__/__snapshots__
- add-custom-instructions
- system-prompt
- tools
- __tests__
- task
- tools
- webview
- webview-ui/src
- components
- chat
- settings
- context
- i18n/locales/en
26 files changed
+339
-249
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
src/core/prompts/__tests__/__snapshots__/add-custom-instructions/mcp-server-creation-disabled.snap
Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments