fix: use relative paths in Qdrant deletion to match stored pathSegments

- Fixed critical bug where deletions used absolute paths while insertions used relative paths
- This mismatch caused deletion filters to never match any points
- Removed error swallowing for 400 errors now that root cause is fixed
- Added debug logging to help verify correct behavior
- Deletions now actually work as intended

Author: daniel-lxs

src/services/code-index/processors/file-watcher.ts

@@ -216,35 +216,16 @@ export class FileWatcher implements IFileWatcher {
 					errorStatus: errorStatus,
 				})
 
-				// Check if this is a bad request error that we should handle gracefully
-				if (errorStatus === 400 || errorMessage.toLowerCase().includes("bad request")) {
-					console.warn(
-						`[FileWatcher] Received bad request error during deletion for ${allPathsToClearFromDB.size} files. Treating as successful deletion...`,
-					)
-					// Treat as successful deletion - remove from cache and mark as success
-					for (const path of pathsToExplicitlyDelete) {
-						this.cacheManager.deleteHash(path)
-						batchResults.push({ path, status: "success" })
-						processedCountInBatch++
-						this._onBatchProgressUpdate.fire({
-							processedInBatch: processedCountInBatch,
-							totalInBatch: totalFilesInBatch,
-							currentFile: path,
-						})
-					}
-				} else {
-					// For other errors, mark as error but don't set overallBatchError
-					// This allows the rest of the batch to continue processing
-					overallBatchError = error as Error
-					for (const path of pathsToExplicitlyDelete) {
-						batchResults.push({ path, status: "error", error: error as Error })
-						processedCountInBatch++
-						this._onBatchProgressUpdate.fire({
-							processedInBatch: processedCountInBatch,
-							totalInBatch: totalFilesInBatch,
-							currentFile: path,
-						})
-					}
+				// Mark all paths as error
+				overallBatchError = error as Error
+				for (const path of pathsToExplicitlyDelete) {
+					batchResults.push({ path, status: "error", error: error as Error })
+					processedCountInBatch++
+					this._onBatchProgressUpdate.fire({
+						processedInBatch: processedCountInBatch,
+						totalInBatch: totalFilesInBatch,
+						currentFile: path,
+					})
 				}
 			}
 		}

src/services/code-index/processors/scanner.ts

@@ -297,15 +297,8 @@ export class DirectoryScanner implements IDirectoryScanner {
 							errorStatus: errorStatus,
 						})
 
-						// Check if this is a bad request error that we should handle gracefully
-						if (errorStatus === 400 || errorMessage.toLowerCase().includes("bad request")) {
-							console.warn(
-								`[DirectoryScanner] Received bad request error when deleting ${cachedFilePath}. File may not exist in vector store. Removing from cache anyway...`,
-							)
-							// Still remove from cache even if vector store deletion failed
-							await this.cacheManager.deleteHash(cachedFilePath)
-						} else if (onError) {
-							// For other errors, report to error handler but don't throw
+						if (onError) {
+							// Report error to error handler
 							onError(
 								error instanceof Error
 									? new Error(
@@ -318,7 +311,8 @@ export class DirectoryScanner implements IDirectoryScanner {
 										),
 							)
 						}
-						// Don't re-throw - allow scanning to continue
+						// Re-throw to maintain consistent error handling
+						throw error
 					}
 				}
 			}
@@ -382,19 +376,11 @@ export class DirectoryScanner implements IDirectoryScanner {
 							errorStatus: errorStatus,
 						})
 
-						// Check if this is a bad request error that we should handle gracefully
-						if (errorStatus === 400 || errorMessage.toLowerCase().includes("bad request")) {
-							console.warn(
-								`[DirectoryScanner] Received bad request error during deletion. Continuing with upsert operation...`,
-							)
-							// Don't throw - continue with the upsert operation
-						} else {
-							// For other errors, re-throw with workspace context
-							throw new Error(
-								`Failed to delete points for ${uniqueFilePaths.length} files. Workspace: ${scanWorkspace}. ${errorMessage}`,
-								{ cause: deleteError },
-							)
-						}
+						// Re-throw with workspace context
+						throw new Error(
+							`Failed to delete points for ${uniqueFilePaths.length} files. Workspace: ${scanWorkspace}. ${errorMessage}`,
+							{ cause: deleteError },
+						)
 					}
 				}
 				// --- End Deletion Step ---

src/services/code-index/vector-store/qdrant-client.ts

@@ -444,11 +444,15 @@ export class QdrantVectorStore implements IVectorStore {
 
 			// Build filters using pathSegments to match the indexed fields
 			const filters = filePaths.map((filePath) => {
-				const absolutePath = path.resolve(workspaceRoot, filePath)
-				const normalizedPath = path.normalize(absolutePath)
+				// IMPORTANT: Use the relative path to match what's stored in upsertPoints
+				// upsertPoints stores the relative filePath, not the absolute path
+				const relativePath = path.isAbsolute(filePath) ? path.relative(workspaceRoot, filePath) : filePath
+
+				// Normalize the relative path
+				const normalizedRelativePath = path.normalize(relativePath)
 
 				// Split the path into segments like we do in upsertPoints
-				const segments = normalizedPath.split(path.sep).filter(Boolean)
+				const segments = normalizedRelativePath.split(path.sep).filter(Boolean)
 
 				// Create a filter that matches all segments of the path
 				// This ensures we only delete points that match the exact file path
@@ -490,16 +494,6 @@ export class QdrantVectorStore implements IVectorStore {
 				samplePaths: filePaths.slice(0, 3),
 			})
 
-			// Check if this is a "bad request" error that we can handle gracefully
-			if (errorStatus === 400 || errorMessage.toLowerCase().includes("bad request")) {
-				console.warn(
-					`[QdrantVectorStore] Received bad request error during deletion. This might indicate the points don't exist or the filter is invalid. Continuing without throwing...`,
-				)
-				// Don't throw the error - allow the indexing process to continue
-				return
-			}
-
-			// For other errors, still throw them
 			throw error
 		}
 	}