refactor: remove unused modelDimension parameter from OpenAiCompatibleEmbedder

- Remove modelDimension property and constructor parameter from OpenAiCompatibleEmbedder class
- Update ServiceFactory to not pass dimension to embedder constructor
- Update tests to match new constructor signature
- The dimension is still used for QdrantVectorStore configuration

Author: daniel-lxs

src/services/code-index/__tests__/service-factory.test.ts

@@ -183,34 +183,6 @@ describe("CodeIndexServiceFactory", () => {
 				"https://api.example.com/v1",
 				"test-api-key",
 				testModelId,
-				undefined,
-			)
-		})
-
-		it("should pass modelDimension to OpenAI Compatible embedder when provided", () => {
-			// Arrange
-			const testModelId = "custom-model"
-			const testDimension = 1024
-			const testConfig = {
-				embedderProvider: "openai-compatible",
-				modelId: testModelId,
-				openAiCompatibleOptions: {
-					baseUrl: "https://api.example.com/v1",
-					apiKey: "test-api-key",
-					modelDimension: testDimension,
-				},
-			}
-			mockConfigManager.getConfig.mockReturnValue(testConfig as any)
-
-			// Act
-			factory.createEmbedder()
-
-			// Assert
-			expect(MockedOpenAiCompatibleEmbedder).toHaveBeenCalledWith(
-				"https://api.example.com/v1",
-				"test-api-key",
-				testModelId,
-				testDimension,
 			)
 		})
 
@@ -234,7 +206,6 @@ describe("CodeIndexServiceFactory", () => {
 				"https://api.example.com/v1",
 				"test-api-key",
 				undefined,
-				undefined,
 			)
 		})
 

src/services/code-index/embedders/openai-compatible.ts

@@ -14,16 +14,14 @@ import {
 export class OpenAiCompatibleEmbedder implements IEmbedder {
 	private embeddingsClient: OpenAI
 	private readonly defaultModelId: string
-	private readonly modelDimension?: number
 
 	/**
 	 * Creates a new OpenAI Compatible embedder
 	 * @param baseUrl The base URL for the OpenAI-compatible API endpoint
 	 * @param apiKey The API key for authentication
 	 * @param modelId Optional model identifier (defaults to "text-embedding-3-small")
-	 * @param dimension Optional embedding dimension for the model
 	 */
-	constructor(baseUrl: string, apiKey: string, modelId?: string, dimension?: number) {
+	constructor(baseUrl: string, apiKey: string, modelId?: string) {
 		if (!baseUrl) {
 			throw new Error("Base URL is required for OpenAI Compatible embedder")
 		}
@@ -36,7 +34,6 @@ export class OpenAiCompatibleEmbedder implements IEmbedder {
 			apiKey: apiKey,
 		})
 		this.defaultModelId = modelId || "text-embedding-3-small"
-		this.modelDimension = dimension
 	}
 
 	/**

src/services/code-index/service-factory.ts

@@ -52,7 +52,6 @@ export class CodeIndexServiceFactory {
 				config.openAiCompatibleOptions.baseUrl,
 				config.openAiCompatibleOptions.apiKey,
 				config.modelId,
-				config.openAiCompatibleOptions.modelDimension, // Pass the dimension
 			)
 		}