feat: add VSCode setting to control todo completion prevention

- Add preventCompletionWithOpenTodos setting (default: false)
- Update attemptCompletionTool to check setting before enforcing validation
- Add comprehensive tests for setting behavior
- Include setting in IPC configuration and global settings schema
- Add localization for the new setting

Author: roomote

packages/types/src/global-settings.ts

@@ -51,6 +51,7 @@ export const globalSettingsSchema = z.object({
 	allowedCommands: z.array(z.string()).optional(),
 	deniedCommands: z.array(z.string()).optional(),
 	commandExecutionTimeout: z.number().optional(),
+	preventCompletionWithOpenTodos: z.boolean().optional(),
 	allowedMaxRequests: z.number().nullish(),
 	autoCondenseContext: z.boolean().optional(),
 	autoCondenseContextPercent: z.number().optional(),
@@ -202,6 +203,7 @@ export const EVALS_SETTINGS: RooCodeSettings = {
 	followupAutoApproveTimeoutMs: 0,
 	allowedCommands: ["*"],
 	commandExecutionTimeout: 30_000,
+	preventCompletionWithOpenTodos: false,
 
 	browserToolEnabled: false,
 	browserViewportSize: "900x600",

src/core/tools/__tests__/attemptCompletionTool.spec.ts

@@ -9,8 +9,25 @@ vi.mock("../../prompts/responses", () => ({
 	},
 }))
 
+// Mock vscode module
+vi.mock("vscode", () => ({
+	workspace: {
+		getConfiguration: vi.fn(() => ({
+			get: vi.fn(),
+		})),
+	},
+}))
+
+// Mock Package module
+vi.mock("../../../shared/package", () => ({
+	Package: {
+		name: "roo-cline",
+	},
+}))
+
 import { attemptCompletionTool } from "../attemptCompletionTool"
 import { Task } from "../../task/Task"
+import * as vscode from "vscode"
 
 describe("attemptCompletionTool", () => {
 	let mockTask: Partial<Task>
@@ -20,6 +37,7 @@ describe("attemptCompletionTool", () => {
 	let mockRemoveClosingTag: ReturnType<typeof vi.fn>
 	let mockToolDescription: ReturnType<typeof vi.fn>
 	let mockAskFinishSubTaskApproval: ReturnType<typeof vi.fn>
+	let mockGetConfiguration: ReturnType<typeof vi.fn>
 
 	beforeEach(() => {
 		mockPushToolResult = vi.fn()
@@ -28,6 +46,17 @@ describe("attemptCompletionTool", () => {
 		mockRemoveClosingTag = vi.fn()
 		mockToolDescription = vi.fn()
 		mockAskFinishSubTaskApproval = vi.fn()
+		mockGetConfiguration = vi.fn(() => ({
+			get: vi.fn((key: string, defaultValue: any) => {
+				if (key === "preventCompletionWithOpenTodos") {
+					return defaultValue // Default to false unless overridden in test
+				}
+				return defaultValue
+			}),
+		}))
+
+		// Setup vscode mock
+		vi.mocked(vscode.workspace.getConfiguration).mockImplementation(mockGetConfiguration)
 
 		mockTask = {
 			consecutiveMistakeCount: 0,
@@ -224,5 +253,137 @@ describe("attemptCompletionTool", () => {
 				expect.stringContaining("Cannot complete task while there are incomplete todos"),
 			)
 		})
+
+		it("should allow completion when setting is disabled even with incomplete todos", async () => {
+			const block: AttemptCompletionToolUse = {
+				type: "tool_use",
+				name: "attempt_completion",
+				params: { result: "Task completed successfully" },
+				partial: false,
+			}
+
+			const todosWithPending: TodoItem[] = [
+				{ id: "1", content: "First task", status: "completed" },
+				{ id: "2", content: "Second task", status: "pending" },
+			]
+
+			mockTask.todoList = todosWithPending
+
+			// Ensure the setting is disabled (default behavior)
+			mockGetConfiguration.mockReturnValue({
+				get: vi.fn((key: string, defaultValue: any) => {
+					if (key === "preventCompletionWithOpenTodos") {
+						return false // Setting is disabled
+					}
+					return defaultValue
+				}),
+			})
+
+			await attemptCompletionTool(
+				mockTask as Task,
+				block,
+				mockAskApproval,
+				mockHandleError,
+				mockPushToolResult,
+				mockRemoveClosingTag,
+				mockToolDescription,
+				mockAskFinishSubTaskApproval,
+			)
+
+			// Should not prevent completion when setting is disabled
+			expect(mockTask.consecutiveMistakeCount).toBe(0)
+			expect(mockTask.recordToolError).not.toHaveBeenCalled()
+			expect(mockPushToolResult).not.toHaveBeenCalledWith(
+				expect.stringContaining("Cannot complete task while there are incomplete todos"),
+			)
+		})
+
+		it("should prevent completion when setting is enabled with incomplete todos", async () => {
+			const block: AttemptCompletionToolUse = {
+				type: "tool_use",
+				name: "attempt_completion",
+				params: { result: "Task completed successfully" },
+				partial: false,
+			}
+
+			const todosWithPending: TodoItem[] = [
+				{ id: "1", content: "First task", status: "completed" },
+				{ id: "2", content: "Second task", status: "pending" },
+			]
+
+			mockTask.todoList = todosWithPending
+
+			// Enable the setting
+			mockGetConfiguration.mockReturnValue({
+				get: vi.fn((key: string, defaultValue: any) => {
+					if (key === "preventCompletionWithOpenTodos") {
+						return true // Setting is enabled
+					}
+					return defaultValue
+				}),
+			})
+
+			await attemptCompletionTool(
+				mockTask as Task,
+				block,
+				mockAskApproval,
+				mockHandleError,
+				mockPushToolResult,
+				mockRemoveClosingTag,
+				mockToolDescription,
+				mockAskFinishSubTaskApproval,
+			)
+
+			// Should prevent completion when setting is enabled and there are incomplete todos
+			expect(mockTask.consecutiveMistakeCount).toBe(1)
+			expect(mockTask.recordToolError).toHaveBeenCalledWith("attempt_completion")
+			expect(mockPushToolResult).toHaveBeenCalledWith(
+				expect.stringContaining("Cannot complete task while there are incomplete todos"),
+			)
+		})
+
+		it("should allow completion when setting is enabled but all todos are completed", async () => {
+			const block: AttemptCompletionToolUse = {
+				type: "tool_use",
+				name: "attempt_completion",
+				params: { result: "Task completed successfully" },
+				partial: false,
+			}
+
+			const completedTodos: TodoItem[] = [
+				{ id: "1", content: "First task", status: "completed" },
+				{ id: "2", content: "Second task", status: "completed" },
+			]
+
+			mockTask.todoList = completedTodos
+
+			// Enable the setting
+			mockGetConfiguration.mockReturnValue({
+				get: vi.fn((key: string, defaultValue: any) => {
+					if (key === "preventCompletionWithOpenTodos") {
+						return true // Setting is enabled
+					}
+					return defaultValue
+				}),
+			})
+
+			await attemptCompletionTool(
+				mockTask as Task,
+				block,
+				mockAskApproval,
+				mockHandleError,
+				mockPushToolResult,
+				mockRemoveClosingTag,
+				mockToolDescription,
+				mockAskFinishSubTaskApproval,
+			)
+
+			// Should allow completion when setting is enabled but all todos are completed
+			expect(mockTask.consecutiveMistakeCount).toBe(0)
+			expect(mockTask.recordToolError).not.toHaveBeenCalled()
+			expect(mockPushToolResult).not.toHaveBeenCalledWith(
+				expect.stringContaining("Cannot complete task while there are incomplete todos"),
+			)
+		})
 	})
 })

src/core/tools/attemptCompletionTool.ts

@@ -1,4 +1,5 @@
 import Anthropic from "@anthropic-ai/sdk"
+import * as vscode from "vscode"
 
 import { TelemetryService } from "@roo-code/telemetry"
 
@@ -14,6 +15,7 @@ import {
 	AskFinishSubTaskApproval,
 } from "../../shared/tools"
 import { formatResponse } from "../prompts/responses"
+import { Package } from "../../shared/package"
 
 export async function attemptCompletionTool(
 	cline: Task,
@@ -28,10 +30,15 @@ export async function attemptCompletionTool(
 	const result: string | undefined = block.params.result
 	const command: string | undefined = block.params.command
 
-	// Check if there are incomplete todos
+	// Get the setting for preventing completion with open todos from VSCode configuration
+	const preventCompletionWithOpenTodos = vscode.workspace
+		.getConfiguration(Package.name)
+		.get<boolean>("preventCompletionWithOpenTodos", false)
+
+	// Check if there are incomplete todos (only if the setting is enabled)
 	const hasIncompleteTodos = cline.todoList && cline.todoList.some((todo) => todo.status !== "completed")
 
-	if (hasIncompleteTodos) {
+	if (preventCompletionWithOpenTodos && hasIncompleteTodos) {
 		cline.consecutiveMistakeCount++
 		cline.recordToolError("attempt_completion")
 		pushToolResult(

src/package.json

@@ -345,6 +345,11 @@
 					"maximum": 600,
 					"description": "%commands.commandExecutionTimeout.description%"
 				},
+				"roo-cline.preventCompletionWithOpenTodos": {
+					"type": "boolean",
+					"default": false,
+					"description": "%commands.preventCompletionWithOpenTodos.description%"
+				},
 				"roo-cline.vsCodeLmModelSelector": {
 					"type": "object",
 					"properties": {

src/package.nls.json

@@ -29,6 +29,7 @@
 	"commands.allowedCommands.description": "Commands that can be auto-executed when 'Always approve execute operations' is enabled",
 	"commands.deniedCommands.description": "Command prefixes that will be automatically denied without asking for approval. In case of conflicts with allowed commands, the longest prefix match takes precedence. Add * to deny all commands.",
 	"commands.commandExecutionTimeout.description": "Maximum time in seconds to wait for command execution to complete before timing out (0 = no timeout, 1-600s, default: 0s)",
+	"commands.preventCompletionWithOpenTodos.description": "Prevent task completion when there are incomplete todos in the todo list (default: false)",
 	"settings.vsCodeLmModelSelector.description": "Settings for VSCode Language Model API",
 	"settings.vsCodeLmModelSelector.vendor.description": "The vendor of the language model (e.g. copilot)",
 	"settings.vsCodeLmModelSelector.family.description": "The family of the language model (e.g. gpt-4)",