fix: enhance Bedrock error messages in retry system

- Throw enhanced error messages instead of original errors in createMessage() and completePrompt()
- Users now see detailed error codes, request IDs, and troubleshooting guidance during retry countdowns
- Add comprehensive tests to verify enhanced error messages flow to retry system
- Resolves issue #4745 where retry messages only showed basic errors instead of verbose details

Author: hannesrudolph

src/api/providers/__tests__/bedrock-error-handling.spec.ts

@@ -389,4 +389,74 @@ describe("AwsBedrockHandler Error Handling", () => {
 			}
 		})
 	})
+
+	describe("Enhanced Error Throw for Retry System", () => {
+		it("should throw enhanced error messages for completePrompt to display in retry system", async () => {
+			const throttlingError = createMockError({
+				message: "Too many tokens, rate limited",
+				status: 429,
+				$metadata: {
+					httpStatusCode: 429,
+					requestId: "test-request-id-12345",
+				},
+			})
+			mockSend.mockRejectedValueOnce(throttlingError)
+
+			try {
+				await handler.completePrompt("test")
+				throw new Error("Expected error to be thrown")
+			} catch (error) {
+				// Should contain error codes (note: completePrompt adds "Bedrock completion error: " prefix)
+				expect(error.message).toContain("[HTTP 429")
+				// Should contain the verbose message template
+				expect(error.message).toContain("Request was throttled or rate limited")
+				// Should contain debug information
+				expect(error.message).toContain("Request ID: test-request-id-12345")
+				// Should preserve original error properties
+				expect((error as any).status).toBe(429)
+				expect((error as any).$metadata.requestId).toBe("test-request-id-12345")
+			}
+		})
+
+		it("should throw enhanced error messages for createMessage streaming to display in retry system", async () => {
+			const tokenError = createMockError({
+				message: "Too many tokens in request",
+				name: "ValidationException",
+				$metadata: {
+					httpStatusCode: 400,
+					requestId: "token-error-id-67890",
+					extendedRequestId: "extended-12345",
+				},
+			})
+
+			const mockStream = {
+				[Symbol.asyncIterator]() {
+					return {
+						async next() {
+							throw tokenError
+						},
+					}
+				},
+			}
+
+			mockSend.mockResolvedValueOnce({ stream: mockStream })
+
+			try {
+				const stream = handler.createMessage("system", [{ role: "user", content: "test" }])
+				for await (const chunk of stream) {
+					// Should not reach here as it should throw an error
+				}
+				throw new Error("Expected error to be thrown")
+			} catch (error) {
+				// Should contain error codes (note: this will be caught by the non-throttling error path)
+				expect(error.message).toContain("Too many tokens")
+				// Should contain debug information
+				expect(error.message).toContain("Request ID: token-error-id-67890")
+				expect(error.message).toContain("Extended Request ID: extended-12345")
+				// Should preserve original error properties
+				expect(error.name).toBe("ValidationException")
+				expect((error as any).$metadata.requestId).toBe("token-error-id-67890")
+			}
+		})
+	})
 })

src/api/providers/bedrock.ts

@@ -581,9 +581,19 @@ export class AwsBedrockHandler extends BaseProvider implements SingleCompletionH
 				yield chunk as any // Cast to any to bypass type checking since we know the structure is correct
 			}
 
-			// Re-throw the error
+			// Re-throw with enhanced error message so retry system shows verbose details
+			const enhancedErrorMessage = this.formatErrorMessage(error, this.getErrorType(error), true)
 			if (error instanceof Error) {
-				throw error
+				const enhancedError = new Error(enhancedErrorMessage)
+				// Preserve important properties from the original error
+				enhancedError.name = error.name
+				if ((error as any).status) {
+					;(enhancedError as any).status = (error as any).status
+				}
+				if ((error as any).$metadata) {
+					;(enhancedError as any).$metadata = (error as any).$metadata
+				}
+				throw enhancedError
 			} else {
 				throw new Error("An unknown error occurred")
 			}
@@ -651,7 +661,20 @@ export class AwsBedrockHandler extends BaseProvider implements SingleCompletionH
 			const errorResult = this.handleBedrockError(error, false) // false for non-streaming context
 			// Since we're in a non-streaming context, we know the result is a string
 			const errorMessage = errorResult as string
-			throw new Error(errorMessage)
+
+			// Create enhanced error with verbose details for retry system
+			const enhancedError = new Error(errorMessage)
+			if (error instanceof Error) {
+				// Preserve important properties from the original error
+				enhancedError.name = error.name
+				if ((error as any).status) {
+					;(enhancedError as any).status = (error as any).status
+				}
+				if ((error as any).$metadata) {
+					;(enhancedError as any).$metadata = (error as any).$metadata
+				}
+			}
+			throw enhancedError
 		}
 	}