Apply suggestions from code review

Co-authored-by: Daniel <[email protected]>

Author: felixAnhalt

src/core/webview/webviewMessageHandler.ts

@@ -68,7 +68,7 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
 			await updateGlobalState("autoCloseRooTabs", autoCloseRooTabs)
 			await provider.postStateToWebview()
 			break
-		case "autoCloseAllRooTabs": // Added new setting
+		case "autoCloseAllRooTabs":
 			const autoCloseAllRooTabs = message.bool ?? false
 			await provider.context.globalState.update("autoCloseAllRooTabs", autoCloseAllRooTabs)
 			// Also update workspace settings

src/shared/ExtensionMessage.ts

@@ -167,7 +167,7 @@ export type ExtensionState = Pick<
 	| "diffEnabled"
 	| "diffViewAutoFocus"
 	| "autoCloseRooTabs"
-	| "autoCloseAllRooTabs" // Added new setting
+	| "autoCloseAllRooTabs"
 	| "fuzzyMatchThreshold"
 	// | "experiments" // Optional in GlobalSettings, required here.
 	| "language"

src/shared/WebviewMessage.ts

@@ -14,7 +14,7 @@ export interface WebviewMessage {
 	type:
 		| "diffViewAutoFocus"
 		| "autoCloseRooTabs"
-		| "autoCloseAllRooTabs" // Added new setting
+		| "autoCloseAllRooTabs"
 		| "apiConfiguration"
 		| "deleteMultipleTasksWithIds"
 		| "currentApiConfigName"

webview-ui/src/components/settings/DiffSettingsControl.tsx

@@ -30,9 +30,8 @@ interface DiffCheckAutoCloseControlProps {
 }
 
 interface DiffCheckAutoCloseAllControlProps {
-	// Added new component interface
 	autoCloseAllRooTabs: boolean
-	disabled: boolean // Added disabled prop
+	disabled: boolean
 	onChange: (e: any) => void
 }
 
@@ -74,7 +73,6 @@ const DiffViewAutoCloseAllControl: React.FC<DiffCheckAutoCloseAllControlProps> =
 	disabled,
 	onChange,
 }) => {
-	// Added new component
 	const { t } = useAppTranslation()
 	return (
 		<div>
@@ -119,7 +117,7 @@ export const DiffSettingsControl: React.FC<DiffSettingsControlProps> = ({
 	diffEnabled = true,
 	diffViewAutoFocus = true,
 	autoCloseRooTabs = false,
-	autoCloseAllRooTabs = false, // Added new setting
+	autoCloseAllRooTabs = false,
 	fuzzyMatchThreshold = 1.0,
 	onChange,
 }) => {
@@ -158,7 +156,6 @@ export const DiffSettingsControl: React.FC<DiffSettingsControlProps> = ({
 	)
 
 	const handleAutoCloseAllRooTabsChange = useCallback(
-		// Added new handler
 		(e: any) => {
 			onChange("autoCloseAllRooTabs", e.target.checked)
 		},
@@ -190,7 +187,7 @@ export const DiffSettingsControl: React.FC<DiffSettingsControlProps> = ({
 						autoCloseRooTabs={autoCloseRooTabs}
 						onChange={handleAutoCloseRooTabsChange}
 					/>
-					<DiffViewAutoCloseAllControl // Added new component
+					<DiffViewAutoCloseAllControl
 						autoCloseAllRooTabs={autoCloseAllRooTabs}
 						disabled={!autoCloseRooTabs} // Disabled if autoCloseRooTabs is false
 						onChange={handleAutoCloseAllRooTabsChange}

webview-ui/src/components/settings/SettingsView.tsx

@@ -139,7 +139,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 		enableCheckpoints,
 		diffViewAutoFocus,
 		autoCloseRooTabs,
-		autoCloseAllRooTabs, // Added new setting
+		autoCloseAllRooTabs,
 		diffEnabled,
 		experiments,
 		fuzzyMatchThreshold,
@@ -288,7 +288,7 @@ const SettingsView = forwardRef<SettingsViewRef, SettingsViewProps>(({ onDone, t
 			vscode.postMessage({ type: "diffEnabled", bool: diffEnabled })
 			vscode.postMessage({ type: "diffViewAutoFocus", bool: diffViewAutoFocus })
 			vscode.postMessage({ type: "autoCloseRooTabs", bool: autoCloseRooTabs })
-			vscode.postMessage({ type: "autoCloseAllRooTabs", bool: autoCloseAllRooTabs }) // Send new setting
+			vscode.postMessage({ type: "autoCloseAllRooTabs", bool: autoCloseAllRooTabs })
 			vscode.postMessage({ type: "enableCheckpoints", bool: enableCheckpoints })
 			vscode.postMessage({ type: "browserViewportSize", text: browserViewportSize })
 			vscode.postMessage({ type: "remoteBrowserHost", text: remoteBrowserHost })

webview-ui/src/context/ExtensionStateContext.tsx

@@ -70,7 +70,7 @@ export interface ExtensionStateContextType extends ExtensionState {
 	setDiffEnabled: (value: boolean) => void
 	setDiffViewAutoFocus: (value: boolean) => void
 	setAutoCloseRooTabs: (value: boolean) => void
-	setAutoCloseAllRooTabs: (value: boolean) => void // Added new setter
+	setAutoCloseAllRooTabs: (value: boolean) => void
 	setEnableCheckpoints: (value: boolean) => void
 	setBrowserViewportSize: (value: string) => void
 	setFuzzyMatchThreshold: (value: number) => void