fix: dispose view using .dispose

Author: elianiva

src/activate/__tests__/registerCommands.test.ts

@@ -55,7 +55,7 @@ describe("getVisibleProviderOrLog", () => {
 
 		expect(result).toBeUndefined()
 		expect(mockOutputChannel.appendLine).toHaveBeenCalledWith(
-			"Cannot find any active and visible Roo Code provider instances.",
+			"Cannot find any active and visible Roo Code provider instance.",
 		)
 	})
 })

src/core/webview/ClineProvider.ts

@@ -446,15 +446,17 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements
 					}
 					// For tab panels, their onDidDispose is handled where they are created
 					// (see: openClineInNewTab, which calls setPanel(undefined, "tab"))
-					this.view = undefined
+					if ("dispose" in this.view) {
+						this.view.dispose()
+					}
 					this.log("Cleared this.view reference due to webview disposal.")
 				}
 				// Do NOT call this.dispose() for the provider instance here.
 				// Provider-level disposables are managed by the main dispose() method.
 				// This should only handle the disposal of the webview view itself.
 			},
 			null,
-			this.context.subscriptions,
+			this.disposables,
 		)
 
 		// Listen for when color changes
@@ -581,13 +583,7 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements
 	}
 
 	public async postMessageToWebview(message: ExtensionMessage) {
-		if (this.view && this.view.webview) {
-			await this.view.webview.postMessage(message)
-		} else {
-			this.outputChannel.appendLine(
-				`Cannot post message to webview (${this.viewType}): Webview is not available. Message type: ${message.type}`,
-			)
-		}
+		await this.view?.webview.postMessage(message)
 	}
 
 	private async getHMRHtmlContent(webview: vscode.Webview): Promise<string> {

src/core/webview/__tests__/ClineProvider.test.ts

@@ -227,6 +227,11 @@ jest.mock("../../../integrations/misc/extract-text", () => ({
 	}),
 }))
 
+jest.mock("../../../activate/registerCommands.ts", () => ({
+	getPanel: jest.fn(),
+	setPanel: jest.fn(),
+}))
+
 afterAll(() => {
 	jest.restoreAllMocks()
 })
@@ -310,6 +315,9 @@ describe("ClineProvider", () => {
 			onDidChangeVisibility: jest.fn().mockImplementation(() => ({ dispose: jest.fn() })),
 		} as unknown as vscode.WebviewView
 
+		const { getPanel } = require("../../../activate/registerCommands")
+		;(getPanel as jest.Mock).mockReturnValue(mockWebviewView)
+
 		provider = new ClineProvider(mockContext, mockOutputChannel, "sidebar", new ContextProxy(mockContext))
 
 		defaultTaskOptions = {