Decision: Leave readModelsFromCache as public

diarmidmackenzie · diarmidmackenzie · commit 2fb658c18c97 · 2025-04-01T14:06:42.000+01:00
diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts
@@ -897,7 +897,6 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements
 		await fs.writeFile(path.join(cacheDir, filename), JSON.stringify(data))
 	}
 
-	// not private, so it can be accessed from webviewMessageHandler
 	async readModelsFromCache(filename: string): Promise<Record<string, ModelInfo> | undefined> {
 		const filePath = path.join(await this.ensureCacheDirectoryExists(), filename)
 		const fileExists = await fileExistsAtPath(filePath)

Original file line number	Diff line number	Diff line change
`@@ -897,7 +897,6 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements`
`897`	`897`	`await fs.writeFile(path.join(cacheDir, filename), JSON.stringify(data))`
`898`	`898`	`}`
`899`	`899`
`900`		`- // not private, so it can be accessed from webviewMessageHandler`
`901`	`900`	`async readModelsFromCache(filename: string): Promise<Record<string, ModelInfo> \| undefined> {`
`902`	`901`	`const filePath = path.join(await this.ensureCacheDirectoryExists(), filename)`
`903`	`902`	`const fileExists = await fileExistsAtPath(filePath)`