Skip to content

Commit 32feda2

Browse files
committed
Makes AutoApproveDropdown responsive: single-column when narrow, no overflow outside of the viewport; bonus: shows selection in tooltip when not null
1 parent 29641c1 commit 32feda2

File tree

19 files changed

+334
-115
lines changed

19 files changed

+334
-115
lines changed

webview-ui/src/components/chat/AutoApproveDropdown.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ export const AutoApproveDropdown = ({ disabled = false, triggerClassName = "" }:
197197
align="start"
198198
sideOffset={4}
199199
container={portalContainer}
200-
className="p-0 overflow-hidden min-w-90 max-w-9/10"
200+
className="p-0 overflow-hidden w-[min(440px,calc(100vw-2rem))]"
201201
onOpenAutoFocus={(e) => e.preventDefault()}>
202202
<div className="flex flex-col w-full">
203203
{/* Header with description */}
@@ -215,7 +215,7 @@ export const AutoApproveDropdown = ({ disabled = false, triggerClassName = "" }:
215215
{t("chat:autoApprove.description")}
216216
</p>
217217
</div>
218-
<div className="grid grid-cols-2 gap-x-2 gap-y-2 p-3">
218+
<div className="grid grid-cols-1 min-[340px]:grid-cols-2 gap-x-2 gap-y-2 p-3">
219219
{settingsArray.map(({ key, labelKey, descriptionKey, icon }) => {
220220
const isEnabled = toggles[key]
221221
return (
@@ -224,6 +224,7 @@ export const AutoApproveDropdown = ({ disabled = false, triggerClassName = "" }:
224224
onClick={() => onAutoApproveToggle(key, !isEnabled)}
225225
className={cn(
226226
"flex items-center gap-2 px-2 py-2 rounded text-sm text-left",
227+
"",
227228
"transition-all duration-150",
228229
"opacity-100 hover:opacity-70",
229230
"cursor-pointer",

webview-ui/src/i18n/locales/ca/chat.json

Lines changed: 21 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/de/chat.json

Lines changed: 18 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/en/chat.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,8 @@
271271
"issues": "It seems like you're having Windows PowerShell issues, please see this"
272272
},
273273
"autoApprove": {
274-
"tooltip": "Manage auto-approval settings",
274+
"tooltipManage": "Manage auto-approval settings",
275+
"tooltipStatus": "Auto-approval enabled for: {{toggles}}",
275276
"title": "Auto-approve",
276277
"all": "All",
277278
"none": "None",

webview-ui/src/i18n/locales/es/chat.json

Lines changed: 21 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/fr/chat.json

Lines changed: 19 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/hi/chat.json

Lines changed: 20 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webview-ui/src/i18n/locales/id/chat.json

Lines changed: 26 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)