refactor: remove unnecessary await from scrollToFirstDiff calls

daniel-lxs · daniel-lxs · commit 34492c898075 · 2025-07-03T19:36:46.000-05:00
diff --git a/src/core/tools/applyDiffTool.ts b/src/core/tools/applyDiffTool.ts
@@ -145,7 +145,7 @@ export async function applyDiffToolLegacy(
 			cline.diffViewProvider.editType = "modify"
 			await cline.diffViewProvider.open(relPath)
 			await cline.diffViewProvider.update(diffResult.content, true)
-			await cline.diffViewProvider.scrollToFirstDiff()
+			cline.diffViewProvider.scrollToFirstDiff()
 
 			const completeMessage = JSON.stringify({
 				...sharedMessageProps,
diff --git a/src/core/tools/insertContentTool.ts b/src/core/tools/insertContentTool.ts
@@ -110,7 +110,7 @@ export async function insertContentTool(
 			// First open with original content
 			await cline.diffViewProvider.open(relPath)
 			await cline.diffViewProvider.update(fileContent, false)
-			await cline.diffViewProvider.scrollToFirstDiff()
+			cline.diffViewProvider.scrollToFirstDiff()
 			await delay(200)
 		}
 
diff --git a/src/core/tools/multiApplyDiffTool.ts b/src/core/tools/multiApplyDiffTool.ts
@@ -505,7 +505,7 @@ ${errorDetails ? `\nTechnical details:\n${errorDetails}\n` : ""}
 				cline.diffViewProvider.editType = "modify"
 				await cline.diffViewProvider.open(relPath)
 				await cline.diffViewProvider.update(originalContent!, true)
-				await cline.diffViewProvider.scrollToFirstDiff()
+				cline.diffViewProvider.scrollToFirstDiff()
 
 				// For batch operations, we've already gotten approval
 				const isWriteProtected = cline.rooProtectedController?.isWriteProtected(relPath) || false
diff --git a/src/core/tools/searchAndReplaceTool.ts b/src/core/tools/searchAndReplaceTool.ts
@@ -203,7 +203,7 @@ export async function searchAndReplaceTool(
 			await cline.ask("tool", JSON.stringify(sharedMessageProps), true).catch(() => {})
 			await cline.diffViewProvider.open(validRelPath)
 			await cline.diffViewProvider.update(fileContent, false)
-			await cline.diffViewProvider.scrollToFirstDiff()
+			cline.diffViewProvider.scrollToFirstDiff()
 			await delay(200)
 		}
 
diff --git a/src/core/tools/writeToFileTool.ts b/src/core/tools/writeToFileTool.ts
@@ -164,7 +164,7 @@ export async function writeToFileTool(
 			)
 
 			await delay(300) // wait for diff view to update
-			await cline.diffViewProvider.scrollToFirstDiff()
+			cline.diffViewProvider.scrollToFirstDiff()
 
 			// Check for code omissions before proceeding
 			if (detectCodeOmission(cline.diffViewProvider.originalContent || "", newContent, predictedLineCount)) {
diff --git a/src/integrations/editor/DiffViewProvider.ts b/src/integrations/editor/DiffViewProvider.ts
@@ -540,7 +540,7 @@ export class DiffViewProvider {
 		}
 	}
 
-	async scrollToFirstDiff() {
+	scrollToFirstDiff() {
 		if (!this.activeDiffEditor) {
 			return
 		}

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ export async function insertContentTool(`
`110`	`110`	`// First open with original content`
`111`	`111`	`await cline.diffViewProvider.open(relPath)`
`112`	`112`	`await cline.diffViewProvider.update(fileContent, false)`
`113`		`- await cline.diffViewProvider.scrollToFirstDiff()`
	`113`	`+ cline.diffViewProvider.scrollToFirstDiff()`
`114`	`114`	`await delay(200)`
`115`	`115`	`}`
`116`	`116`
Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ export async function searchAndReplaceTool(`
`203`	`203`	`await cline.ask("tool", JSON.stringify(sharedMessageProps), true).catch(() => {})`
`204`	`204`	`await cline.diffViewProvider.open(validRelPath)`
`205`	`205`	`await cline.diffViewProvider.update(fileContent, false)`
`206`		`- await cline.diffViewProvider.scrollToFirstDiff()`
	`206`	`+ cline.diffViewProvider.scrollToFirstDiff()`
`207`	`207`	`await delay(200)`
`208`	`208`	`}`
`209`	`209`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ export async function writeToFileTool(`
`164`	`164`	`)`
`165`	`165`
`166`	`166`	`await delay(300) // wait for diff view to update`
`167`		`- await cline.diffViewProvider.scrollToFirstDiff()`
	`167`	`+ cline.diffViewProvider.scrollToFirstDiff()`
`168`	`168`
`169`	`169`	`// Check for code omissions before proceeding`
`170`	`170`	`if (detectCodeOmission(cline.diffViewProvider.originalContent \|\| "", newContent, predictedLineCount)) {`
Original file line number	Diff line number	Diff line change
`@@ -540,7 +540,7 @@ export class DiffViewProvider {`
`540`	`540`	`}`
`541`	`541`	`}`
`542`	`542`
`543`		`- async scrollToFirstDiff() {`
	`543`	`+ scrollToFirstDiff() {`
`544`	`544`	`if (!this.activeDiffEditor) {`
`545`	`545`	`return`
`546`	`546`	`}`